Bug 54235 – Konqueror opens external viewer to see an image, instead of showing it in the built-in viewer.

• Product: Gentoo Linux
• Status: RESOLVED UPSTREAM

[Description Mario Doria 2004-06-17 16:26:10 UTC]

Using Konqueror as a File Manager, I select a JPEG image and then go to the "Edit File Type image/jpeg" dialog -> Embedding tab. There, I select "Show file in separate viewer" and my selected separate viewer is Kuickshow. Now I can open any JPEG image by clicking on it. 
 
 The problem is than when using Konqueror (=3.2.2) as a web browser, each time I access an URL like http://www.example.com/image.jpg directly (by typing the address in the Location bar, or by opening a new tab with the image) it tries to open Kuickshow instead of showing it inside Konqueror. By downgrading only Konqueror to version 3.2.1 the problem dissapears. 
 
 The expected behaviour would be for Konqueror to show the image inside it instead of trying to open an external viewer. This also happens with text files (http://www.example.com/textfile.txt) by opening Kate instead of showing it inside Konqueror. 
 
 If I just click on a link in an HTML file (http://www.example.com/index.html) it opens the file inside Konqueror all right. This just happens when accessing the file directly with Konqueror. 

This is a bug that I also reported at bugs.kde.org, the bug ID is 83153


Reproducible: Always
Steps to Reproduce:





I made a diff that fixes this: 
 
--- konqueror/konq_mainwindow.cc        2004-06-17 17:18:48.974228300 -0500 
+++ konqueror/konq_mainwindow.cc        2004-06-17 17:18:36.227396301 -0500 
     // Built-in view ? 
@@ -799,19 +800,9 @@ 
           bool forceAutoEmbed = req.forceAutoEmbed; 
           if ( !req.typedURL.isEmpty() ) // the user _typed_ the URL, he 
wants it in Konq. 
               forceAutoEmbed = true; 
-          if ( url.protocol() == "about" ) 
-              forceAutoEmbed = true; 
-          // Related to KonqFactory::createView 
-          if ( !forceAutoEmbed 
&& !KonqFMSettings::settings()->shouldEmbed( serviceType ) ) 
-          { 
-              kdDebug(1202) << "openView: KonqFMSettings says: don't embed 
this servicetype" << endl; 
-              ok = false; 
-          } 
- 
-          // If the protocol doesn't support writing (e.g. HTTP) then we 
might want to save instead of just embedding. 
-          // So (if embedding would succeed, hence the checks above) we ask 
the user 
-          // Otherwise the user will get asked 'open or save' in openURL 
anyway. 
-          if ( ok && !forceAutoEmbed 
&& !KProtocolInfo::supportsWriting( url ) ) { 
+          // If the protocol doesn't support writing (e.g. HTTP) then we 
don't want the FM settings. 
+          // So we ask the user, instead, except in some very well-known 
cases. 
+          if ( !forceAutoEmbed && !KProtocolInfo::supportsWriting( url ) && 
url.protocol() != "about" ) { 
               QString suggestedFilename; 
 
               KonqRun* run = childView->run(); 
 
 
 
Should be placed in portage/kde-base/kdebase/files/3.2.3 and add 
epatch ${FILESDIR}/${PVR}/konqueror.diff 
 
at the end of src_compile in the kdebase-3.2.3.ebuild

[Comment 1 Carsten Lohrke (RETIRED) 2004-06-20 05:51:34 UTC]

We don't have the man power to maintain such patches, so unless a major feature is broken or a security hotfix is needed, I'm sorry to decline. As you write, Mario - the issue is known upstream. btw.: If you have bugfixes, ebuilds or patches, please attach them. Thanks.