| Summary: | webapp.eclass: reduce webapp_serverowned() verbosity | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Bernard Cafarelli <voyageur> |
| Component: | Eclasses | Assignee: | Gentoo Web Application Packages Maintainers <web-apps> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jerome.melis |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Just drop it. Even that one line doesn't really give you useful info.
--- webapp.eclass.orig 2015-05-09 13:08:19.959802884 -0400
+++ webapp.eclass 2015-05-09 13:09:03.476804865 -0400
@@ -244,7 +244,6 @@
local my_file="$(webapp_strip_appdir "${1}")"
my_file="$(webapp_strip_cwd "${my_file}")"
- elog "(server owned) ${my_file}"
echo "${my_file}" >> "${D}/${WA_SOLIST}"
}
Thanks, I just committed it :) |
Detailed output from webapp_serverowned (especially with -R) can be quite noisy with modern webapps, has limited use, and reduces the log readability For example, www-apps/owncloud has a bundle of applications (outside the core) delivered with the standard tarball, which amount to 6000 files (more like 4800 with 8.0, but still), which imply the same amount of elog lines from this install line: webapp_serverowned -R "${MY_HTDOCSDIR}"/apps This makes other log messages (like webapp-config output, or post-install.txt display) lost in the console buffer, or missed by the user (see #539694 for an example). We could move the elog call to webapp_serverowned, and only log one line like "(server owned) (recursive) $@", or drop it completely? A faster implementation for recursive mode would be nice, but that's another feature request :)