Summary: | sys-fs/go-mtpfs-9999 should not use the git-r3 eclass | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | William Hubbs <williamh> |
Component: | Current packages | Assignee: | Rick Farina (Zero_Chaos) <zerochaos> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | go-mtpfs-9999.ebuild.patch |
Description
William Hubbs
2015-02-25 16:17:03 UTC
Created attachment 397490 [details, diff]
go-mtpfs-9999.ebuild.patch
This is the patch that fixes this issue.
The "compiler" as you call it handles vcs directly in a manner completely inconsistent with the expected features of gentoo live packages. if smart-live-rebuild and emerge @smart-live-rebuild are not supported then this is a breakage not a fix. Here is what happens when I run emerge @smart-live-rebuild: --- cut --- emerge: There are no sets to satisfy 'smart-live-rebuild'. The following sets exist: changed-deps downgrade installed live-rebuild module-rebuild preserved-rebuild profile rebuilt-binaries security selected selected-packages selected-sets system unavailable unavailable-binaries world x11-module-rebuild --- cut --- It looks to me like @smart-live-rebuild is not a standard portage set, so I do not feel we should reject this change since it depends on an optional feature. Does the go compiler meet the Gentoo quality requirements, that is: 1. Cache download results in semi-permanent location so that we don't end up refetching on each build? 2. Support some kind of offline mode? (alike EVCS_OFFLINE) 3. [not obligatory but nice to have] Support splitting fetching and checking out phase? |