Summary: | >=dev-libs/leveldb1.10.0-r1: USE=-snappy has no effect | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Luke-Jr <luke-jr+gentoobugs> |
Component: | [OLD] Development | Assignee: | Johan Bergström <bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | patrick |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
leveldb-1.18-r1.ebuild
leveldb-build_detect_platform.patch |
Description
Luke-Jr
2015-02-23 22:39:20 UTC
Looks like the ability to disable snappy and tcmalloc was added by the leveldb-1.9.0-configure.patch file, which was dropped in 1.10+ for some reason. Yep, the build configure script (build_detect_platform) runs tests and adds them unconditionally should you have snappy (or tcmalloc) installed. Suggested approach: 1. Call build_detect_platform from src_configure 2. Remove the call to it from Makefile 3. sed away -l/-D snappy/tcmalloc if not in IUSE 4. Profit Thoughts? Created attachment 397446 [details]
leveldb-1.18-r1.ebuild
implemented my above suggestion
Created attachment 397448 [details, diff]
leveldb-build_detect_platform.patch
Comment on attachment 397446 [details]
leveldb-1.18-r1.ebuild
please post diffs rather than entire files. we can't easily review this.
should be all set now in the tree; thanks for the report! Commit message: Fix USE=-snappy handling http://sources.gentoo.org/dev-libs/leveldb/files/leveldb-1.18-configure.patch?rev=1.1 http://sources.gentoo.org/dev-libs/leveldb/leveldb-1.18-r1.ebuild?rev=1.1 |