Bug 540852 – app-emulation/vmware-player-7.1.0.2496824 version bump

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description Isaac Richter 2015-02-20 20:54:38 UTC]

VMware has released player version 7.1.0.

Reproducible: Always




I have created ebuilds for vmware-player, vmware-modules and vmware-tools that work for me. Your mileage with vmware-modules may vary (depending on the patches needed for your kernel version).

My ebuild also includes systemd service files that might help close #483642.

[Comment 1 Isaac Richter 2015-02-20 20:56:24 UTC]

Created attachment 397090 [details]
vmware-player.tar

[Comment 2 Isaac Richter 2015-02-20 20:57:46 UTC]

Created attachment 397092 [details]
vmware-modules.tar

Patches are sufficient for (and tested to compile against) gentoo-sources-3.17.8-r1. Other kernels may need other patches.

[Comment 3 Isaac Richter 2015-02-20 20:58:22 UTC]

Created attachment 397094 [details]
vmware-tools.ebuild

[Comment 4 Fabio Rossi 2015-02-20 22:23:22 UTC]

out of curiosity, which is the kernel version you are compiling vmware-modules against? I'm using version 3.19 so I'm attaching the additional patches needed for the successful building of the sources. Tests are welcome :-)

[Comment 5 Fabio Rossi 2015-02-20 22:23:57 UTC]

Created attachment 397096 [details]
vmware-modules-patches-kernel-3.19.tar.bz2

[Comment 6 Isaac Richter 2015-02-21 00:47:19 UTC]

(In reply to Fabio Rossi from comment #4)
> out of curiosity, which is the kernel version you are compiling
> vmware-modules against? I'm using version 3.19 so I'm attaching the
> additional patches needed for the successful building of the sources. Tests
> are welcome :-)

Patches were sufficient for sys-kernel/gentoo-sources-3.17.8-r1 (the current latest stable amd64 kernel).

Instead of maintaining per-kernel-version patches, it probably makes sense to adopt the technique used by vmware-tools-patches <https://github.com/rasa/vmware-tools-patches>, and use something like:

#if LINUX_VERSION_CODE <= KERNEL_VERSION(3, 14, 99) 
//original code
#else
//code for linux >= 3.15
#endif

This would allow one set of patches to be used on all kernels. As new gentoo-sources kernels are stabilized (or earlier for ambitious users), the patches can be extended without breaking support in older kernels.

This also simplifies the ebuild, since there wouldn't need to be separate epatch lines for each kernel version.

[Comment 7 Jeroen Roovers (RETIRED) 2015-02-21 09:49:11 UTC]

*** This bug has been marked as a duplicate of bug 531476 ***

[Comment 8 Jeroen Roovers (RETIRED) 2015-02-21 09:49:58 UTC]

Comment on attachment 397090 [details]
vmware-player.tar

Please attach separate text files next time.