Summary: | sys-process/numactl: convert to multilib | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christoph Junghans (RETIRED) <junghans> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | multilib+disabled |
Priority: | Normal | Keywords: | Inclusion, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 510180, 540036 | ||
Attachments: |
patch against gx86
patch against gx86 |
Description
Christoph Junghans (RETIRED)
2015-02-14 04:56:07 UTC
Looks fine. @base-system: please review (In reply to Christoph Junghans from comment #0) numactl is more than a library. you shouldn't waste time building the tools for other ABIs when they aren't used. (In reply to SpanKY from comment #3) > (In reply to Christoph Junghans from comment #0) > > numactl is more than a library. you shouldn't waste time building the tools > for other ABIs when they aren't used. Sure, but on my machine the compile time difference is minimal, "make -j1 all" took 7.3s while "make -j1 libnuma.la" took 3.5s. In addition the compile part is only a small of the whole merge. So is it worth the hazzle? Technically the solution could be: multilib_src_compile() { multilib_is_native_abi && default || emake libnuma.la } and multilib_src_install() { multilib_is_native_abi && emake DESTDIR="${D}" install || emake DESTDIR="${D}" install-libLTLIBRARIES } Anyhow, your ebuild, your call! Created attachment 396638 [details, diff]
patch against gx86
Updated version of the patch to save compile time.
@vapier: which version do you prefer, the simple or time-saving one? i've fine with the new more complicated version. not everyone has fast machines, so i'd rather elide the compilation entirely. +*numactl-2.0.10-r1 (20 Feb 2015) + + 20 Feb 2015; Christoph Junghans <ottxor@gentoo.org> +numactl-2.0.10-r1.ebuild: + added multilib support (bug #540034) + |