Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 539826

Summary: dev-lang/lua-5.2 - targeting Windows skips DLL build, no EXE file extension
Product: Gentoo Linux Reporter: tschwinger
Component: Current packagesAssignee: William Hubbs <williamh>
Status: RESOLVED FIXED    
Severity: normal CC: dschridde+gentoobugs, jstein, robbat2, tschwinger
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: lua-539828-539826-combined_patch.zip
Lua 5.1 slot ebuild. Pkg versioning only (no Windows fixes see closed #539828 for details)
Properly versioned pkgconfig (see closed #539828 for details)
Diff of pkgconfig files for illustration (see closed #539828 for details)
Lua 5.2 slot ebuild with Windows fixes (see also #539828)
Modified Lua 5.1 ebuild from my local overlay
Modified Lua 5.2 ebuild from my local overlay
Lua 5.1 slot ebuild. Pkg versioning only (no Windows fixes see closed #539828 for details)
Modified Lua 5.1 ebuild from my local overlay

Description tschwinger 2015-02-11 22:53:42 UTC
The ebuild has partial support for Windows and the static libraries build out of the box. 

There is no DLL and EXE files have no extension. See further information.

Reproducible: Always

Steps to Reproduce:
1.Cross-compile -> Windows (remove dependency to eselect-lua so it can work)
2.Look for DLL
3.Look for file extension of executable
Actual Results:  
The DLL is missing. 
Executables have no file name extension.

Expected Results:  
There is a DLL and an executable with an EXE file name extension.

Patch will be attached.
Comment 1 tschwinger 2015-02-11 23:03:09 UTC
Created attachment 396214 [details]
lua-539828-539826-combined_patch.zip

The ZIP contains altered files and diffs of all changed files in a flat folder.
The file 'ISSUES' summarizes the issues addressed. The file 'luav.pc' belongs into ./files of dev-lang/lua/.
Comment 2 tschwinger 2015-02-11 23:06:18 UTC
Comment on attachment 396214 [details]
lua-539828-539826-combined_patch.zip

Pardon. This bug *is* #539826
Comment 3 tschwinger 2015-02-11 23:14:50 UTC
CC seems to be maintainer of the ebuild
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-13 07:53:51 UTC
Comment on attachment 396214 [details]
lua-539828-539826-combined_patch.zip

Please attach plain text files.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-13 07:55:59 UTC
*** Bug 539828 has been marked as a duplicate of this bug. ***
Comment 6 tschwinger 2015-02-13 14:46:23 UTC
Created attachment 396370 [details, diff]
Lua 5.1 slot ebuild. Pkg versioning only (no Windows fixes see closed #539828 for details)
Comment 7 tschwinger 2015-02-13 14:48:11 UTC
Created attachment 396372 [details]
Properly versioned pkgconfig (see closed #539828 for details)
Comment 8 tschwinger 2015-02-13 14:53:03 UTC
Created attachment 396374 [details]
Diff of pkgconfig files for illustration (see closed #539828 for details)

The patch introduces a new pkgconfig template file (luav.pc) because the original (lua.pc) is also used for older ebuilds. This diff is *not* part of the patch and provided for evaluation purposes.
Comment 9 tschwinger 2015-02-13 14:55:30 UTC
Created attachment 396376 [details, diff]
Lua 5.2 slot ebuild with Windows fixes (see also #539828)
Comment 10 tschwinger 2015-02-13 14:56:32 UTC
Created attachment 396378 [details]
Modified Lua 5.1 ebuild from my local overlay
Comment 11 tschwinger 2015-02-13 14:56:59 UTC
Created attachment 396380 [details]
Modified Lua 5.2 ebuild from my local overlay
Comment 12 tschwinger 2015-02-13 15:46:00 UTC
#539828 has been marked a duplicate of this bug. This is actually not quite correct, but I figure it may have pragmatic reasons.

I am attaching all files here.

Please note that #539828 affects the Linux distribution (not just when cross-targeting Windows) and thus has potentially higher priority.

Please also note that the patch changes the pkgconfig-reported location of the headers, which may cause some trouble in some (rather rare) cases, but is very a necessary change to get the slot builds for Lua finally straightened out: Both Autoconf and Cmake should be able to find consistent material for a particular version when looking for it. Other widely-used distros use the same locations. Finally, if some packages fail finding Lua, it's easier to track and fix than version mismatches (that may build and fail when run). I've been using these ebuilds for a while and haven't run into problems.
Comment 13 tschwinger 2015-02-13 17:41:42 UTC
Created attachment 396390 [details, diff]
Lua 5.1 slot ebuild. Pkg versioning only (no Windows fixes see closed #539828 for details)

Whoops had 5.1 and 5.2 ebuilds consistified without testing...
Comment 14 tschwinger 2015-02-13 17:43:11 UTC
Created attachment 396394 [details]
Modified Lua 5.1 ebuild from my local overlay
Comment 15 Larry the Git Cow gentoo-dev 2022-10-13 13:20:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bc1f784b5c91f2e0be1aa06b155cff958ba22a0

commit 1bc1f784b5c91f2e0be1aa06b155cff958ba22a0
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2022-10-13 13:19:37 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2022-10-13 13:19:37 +0000

    dev-lang/lua: drop 5.1.5-r109, 5.3.6-r5, 5.4.4-r2
    
    Bug: https://bugs.gentoo.org/520480
    Bug: https://bugs.gentoo.org/717780
    Closes: https://bugs.gentoo.org/460114
    Closes: https://bugs.gentoo.org/462064
    Closes: https://bugs.gentoo.org/539826
    Closes: https://bugs.gentoo.org/627330
    Closes: https://bugs.gentoo.org/689598
    Closes: https://bugs.gentoo.org/706378
    Closes: https://bugs.gentoo.org/791772
    Closes: https://bugs.gentoo.org/834153
    Closes: https://bugs.gentoo.org/834911
    Closes: https://bugs.gentoo.org/843320
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-lang/lua/Manifest                         |   5 -
 dev-lang/lua/files/configure.in               |   5 -
 dev-lang/lua/files/lua-5.1-module_paths.patch |  30 -----
 dev-lang/lua/files/lua-5.1-readline.patch     |  10 --
 dev-lang/lua/files/lua-5.1.4-deprecated.patch |  46 -------
 dev-lang/lua/files/lua-5.1.5-make.patch       |  97 -------------
 dev-lang/lua/files/lua-5.3.6-make.patch       |  91 -------------
 dev-lang/lua/files/lua-5.4.2-r2-make.patch    |  99 --------------
 dev-lang/lua/files/lua.pc                     |  31 -----
 dev-lang/lua/lua-5.1.5-r109.ebuild            | 145 --------------------
 dev-lang/lua/lua-5.3.6-r5.ebuild              | 187 --------------------------
 dev-lang/lua/lua-5.4.4-r2.ebuild              | 184 -------------------------
 dev-lang/lua/metadata.xml                     |  23 ++--
 13 files changed, 11 insertions(+), 942 deletions(-)