Bug 538484

Summary:	xfce-base/xfce4-panel - xfce4-panel hangs when opening clock plugin settings
Product:	Gentoo Linux	Reporter:	Maxim Mikityanskiy <maxtram95>
Component:	Current packages	Assignee:	XFCE Team <xfce>
Status:	CONFIRMED ---
Severity:	normal	CC:	brakarov, maxtram95
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugzilla.xfce.org/show_bug.cgi?id=11495
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	486532
Bug Blocks:
Attachments:	fix_clock.patch xfce4-panel-4.12.0-r1.ebuild relocate_timezone_path

Description Maxim Mikityanskiy 2015-02-01 23:04:31 UTC

See bug reported upstream: https://bugzilla.xfce.org/show_bug.cgi?id=11495

Since the bug is Gentoo-specific (other distributions does not have /usr/share/zoneinfo/posix -> . symlink), I also report it here. Maybe that symlink pointing to the current directory really sucks and should be replaced by directory /usr/share/zoneinfo/posix with symlinks to all files in /usr/share/zoneinfo (like it is done in Ubuntu)? 

Reproducible: Always

Steps to Reproduce:
1. Right-click on clock widget on xfce4-panel, choose "Properties".
2. The window appears and hangs; panel also hangs.
3. After some long time all things continue to work.
Actual Results:  
Panel hanged for long time.

Expected Results:  
Panel should not hang when I open clock plugin settings.

Comment 1 Geert Braekmans 2015-04-14 11:58:07 UTC

Created attachment 401228 [details, diff]
fix_clock.patch

Comment 2 Geert Braekmans 2015-04-14 12:00:42 UTC

Created attachment 401230 [details]
xfce4-panel-4.12.0-r1.ebuild

I've updated the ebuild to include your (not ideal) patch. This fixes the issue and upstream won't solve the issue for us. I don't think #486532 will be reopened soon, so I think this is the best workaround.

Comment 3 Michał Górny archtester

2015-04-14 22:24:11 UTC

+  14 Apr 2015; Michał Górny <mgorny@gentoo.org> xfce4-panel-4.12.0.ebuild:
+  Add a blocker against broken timezone-data versions, fixes deadlock bug
+  #538484

timezone-data-2015c-r1 doesn't have the posix symlink anymore. I added a blocker against older versions to xfce4-panel, and I guess that's close enough to a fix.

Comment 4 Michał Górny archtester

2015-04-15 20:42:51 UTC

I've reverted the previous change. It seems that the clock applet doesn't work at all with the new timezone-data version, i.e. expects timezones in non-existing 'posix' dir.

Comment 5 Geert Braekmans 2015-04-15 21:27:47 UTC

I've been looking through the source. plugins/clock/clock.c has a define for the timezone dir. Line 54. Should be easy enough to patch. Will try this tomorrow and report back.

Maxim's patch seems to be included upstream though not syntactically identical.

Comment 6 Geert Braekmans 2015-04-16 12:25:31 UTC

Created attachment 401352 [details, diff]
relocate_timezone_path

Here's the patch. Seems to work on my local overlay.