Bug 537226

Summary:	games-puzzle/icebreaker fails to compile with format-security
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	259417
Attachments:	icebreaker-1.9.6:20150121-115130.log

Description Agostino Sarubbo gentoo-dev

2015-01-21 11:53:42 UTC

This is an auto-filled bug because this package fails to compile with format-security. To reproduce use CFLAGS/CXXFLAGS -Werror=format-security.

Other distros (like Fedora/Debian) build with format-security, so you could find patch(es) in their repository.

Major info at https://fedoraproject.org/wiki/Format-Security-FAQ

Portage 2.2.8-r2 (default/linux/amd64/13.0, gcc-4.8.3, glibc-2.19-r1, 3.2.62-hardened-r1-xxxx-std-ipv6-64 x86_64)
=================================================================
System uname: Linux-3.2.62-hardened-r1-xxxx-std-ipv6-64-x86_64-Intel-R-_Xeon-R-_CPU_E3-1245_V2_@_3.40GHz-with-gentoo-2.2
KiB Mem:    32857344 total,   8932248 free
KiB Swap:          0 total,         0 free
ld ld di GNU (Gentoo 2.24 p1.4) 2.24
app-shells/bash:          4.2_p53
dev-java/java-config:     2.2.0
dev-lang/perl:            5.18.2-r2
dev-lang/python:          2.7.7, 3.3.5-r1, 3.4.1
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.13.4
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -Wformat -Werror=format-security -g0 -O2"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cgi-php5.5/ext-active/ 
/etc/php/cli-php5.4/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -Wformat -Werror=format-security -g0 -O2 -Wabi -fabi-version=6"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y --keep-going y -1"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms sign split-log strict unknown-features-warn unmerge-logs 
unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j8"
PKGDIR="/root/.pkg"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl amd64 berkdb bzip2 cairo cli consolekit cracklib crypt cxx dbus dri fortran gdbm gudev hwdb iconv icu ipv6 jpeg minizip mmx modules multilib ncurses nls nptl ogg opengl openmp pam pax_kernel pcre png policykit python qt3support qt4 readline session sse 
sse2 ssl tcpd unicode vorbis zlib" ABI_X86="64" ELIBC="glibc" KERNEL="linux" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="am fil zh af ca cs da de el es et gl hu nb nl pl pt ro ru sk sl sv uk bg cy en eo fo ga he id ku lt lv mk ms nn sw 
tn zu ja zh_TW en_GB pt_BR ko zh_CN ar en_CA fi kk oc sr tr fa wa nds as be bn bn_BD bn_IN en_US es_AR es_CL es_ES es_MX eu fy fy_NL ga_IE gu gu_IN hi hi_IN is ka kn ml mr nn_NO or pa pa_IN pt_PT rm si sq sv_SE ta ta_LK te th vi ast dz km my om sh ug uz 
ca@valencia sr@ijekavian sr@ijekavianlatin sr@latin csb hne mai se es_LA fr_CA zh_HK br la no es_CR et_EE sr_CS bo hsb hy mn sr@Latn lb ne bs tg uz@cyrillic xh be_BY brx ca_XV dgo en_ZA gd kok ks ky lo mni nr ns pap ps rw sa_IN sat sd ss st sw_TZ ti ts ve mt ia 
az me tl ak hy_AM lg nso son ur_PK it fr nb nb_NO hr nan ur tk cs_CZ da_DK de_1901 de_CH en_AU lt_LT pl_PL sa sk_SK th_TH ta_IN tt sco ha mi ven ar_SY el_GR ro_RO ru_RU sl_SI uk_UA vi_VN ar_SY te_IN de_DE es_VE fa_IR fr_FR hu_HU id_ID it_IT ja_JP ka_GE nl_NL 
sr_BA sr_RS ca_ES fi_FI he_IL jv ru_gold yi eu_ES" NGINX_MODULES_HTTP="access auth_basic autoindex browser charset empty_gif fastcgi geo gzip limit_conn limit_req map memcached proxy referer rewrite scgi split_clients ssi upstream_ip_hash userid uwsgi addition 
auth_pam cache_purge dav dav_ext degradation echo fancyindex flv geoip gunzip gzip_static headers_more image_filter lua metrics mp4 naxsi perl push push_stream random_index realip secure_link security slowfs_cache spdy stub_status sub upload_progress 
upstream_check xslt ajp auth_request mogilefs sticky" NGINX_MODULES_MAIL="imap pop3 smtp" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-4 php5-5" PYTHON_SINGLE_TARGET="python2_7 python3_3" PYTHON_TARGETS="python2_7 python3_3" QEMU_USER_TARGETS="aarch64 
alpha arm armeb cris i386 m68k microblaze microblazeel mips mips64 mips64el mipsel mipsn32 mipsn32el or32 ppc ppc64 ppc64abi32 s390x sh4 sh4eb sparc sparc32plus sparc64 unicore32 x86_64" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU"
USE_PYTHON="2.7 3.3"

Comment 1 Agostino Sarubbo gentoo-dev

2015-01-21 11:53:46 UTC

Created attachment 394468 [details]
icebreaker-1.9.6:20150121-115130.log

build log

Comment 2 Ted Tanberry 2015-02-01 19:43:44 UTC

--- icebreaker-1.9.6-gentoo.patch
+++ icebreaker-1.9.6-gentoo.patch
@@ -24,7 +24,7 @@
  	
 --- menu.c
 +++ menu.c
-@@ -193,12 +193,12 @@ PopupReturnType popupoptionsmenu()
+@@ -193,12 +193,12 @@
  
  	if (strlen(commandline.theme)>0)
  	{
@@ -39,16 +39,18 @@
  		originalthemecl=false;	
  	}
  				
-@@ -521,7 +521,7 @@ PopupReturnType menuitem_theme(char * va
+@@ -521,8 +521,8 @@
  		if (((mbutton==1 || mbutton==4) && t==themecount-1) || ((mbutton!=1 && mbutton!=4) && t==0))
  		{ // "random", at the end/beginning of the list
  			
 -			strncpy(val,"random",MAXMENUVALUELENGTH);
+-			snprintf(options.theme,MAXMENUVALUELENGTH,"random");
 +			strcpy(options.theme,"random");
- 			snprintf(options.theme,MAXMENUVALUELENGTH,"random");
++			snprintf(options.theme,MAXTHEMENAMELENGTH,"random");
  			
  			settheme("linux"); // just for pretty
-@@ -538,7 +538,7 @@ PopupReturnType menuitem_theme(char * va
+ 			
+@@ -538,13 +538,13 @@
  			if (mbutton==1 || mbutton==4) // left click or scroll forwards
  			{
  				strncpy(val,themelist[(t+1)%themecount],MAXMENUVALUELENGTH);
@@ -57,6 +59,13 @@
  			}
  			else // right or middle or scroll back
  			{
+ 				if (t<0) t=themecount;
+ 				strncpy(val,themelist[(t-1)%themecount],MAXMENUVALUELENGTH);
+-				snprintf(options.theme,MAXMENUVALUELENGTH,themelist[(t-1)%themecount]);
++				snprintf(options.theme,sizeof(options.theme),"%s",themelist[(t+1)%themecount]);
+ 			}
+ 			
+ 			settheme(options.theme);
 --- hiscore.c
 +++ hiscore.c
 @@ -72,7 +72,7 @@

Comment 3 Ted Tanberry 2015-02-01 19:44:57 UTC

The icebreaker-1.9.6-gentoo.patch was incomplete. I've added the last bit and recommend deleting the icebreaker-1.9.6-ovfl.patch as they both modify the same source (main.c)

Comment 4 Tupone Alfredo gentoo-dev

2016-01-10 20:53:06 UTC

It should be fixed. Thanks for report