Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 537082

Summary: app-emulation/libguestfs needs README.fixed to actually work
Product: Gentoo Linux Reporter: Daniel Augustin <hossie>
Component: [OLD] UnspecifiedAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED DUPLICATE    
Severity: normal CC: hossie
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: 0003_disable_readme_requirement.patch

Description Daniel Augustin 2015-01-19 20:49:49 UTC
The current libguestfs and libguestfs-appliance ebuilds need the file README.fixed be present in the appliance folder.

The current ebuild (appliance) installs these files:

/etc
/etc/env.d
/etc/env.d/99libguestfs-appliance
/usr
/usr/share
/usr/share/doc
/usr/share/doc/libguestfs-appliance-1.28.1
/usr/share/doc/libguestfs-appliance-1.28.1/README.fixed.bz2
/usr/share/guestfs
/usr/share/guestfs/appliance
/usr/share/guestfs/appliance/initrd
/usr/share/guestfs/appliance/kernel
/usr/share/guestfs/appliance/root

when the file README.fixed is not in /usr/share/guestfs/appliance libguestfs doesn't recognize the appliance.

Code snippet:
static int
contains_fixed_appliance (guestfs_h *g, const char *path, void *data)
{
  return dir_contains_files (path,
                             "README.fixed",
                             "kernel", "initrd", "root", NULL);
}

So putting the file into /usr/share/doc is not working here.

We should either put the file into /usr/share/guestfs/appliance or patch libguestfs to recognize the appliance without the readme.

Here is the upstream bug with details and why they don't really want to fix it upstream (or need suggestions on how): https://bugzilla.redhat.com/show_bug.cgi?id=1183780

I have attached a patch (for libguestfs, not libguestfs-appliance) to don't care about README.fixed, worked for me.

As far as I can tell, the current ebuild is not working at all, you can't run any guestfs commands.

Reproducible: Always
Comment 1 Daniel Augustin 2015-01-19 20:50:19 UTC
Created attachment 394356 [details, diff]
0003_disable_readme_requirement.patch
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-19 21:00:56 UTC

*** This bug has been marked as a duplicate of bug 534148 ***