Summary: | sys-apps/portage: show a QA warning when -flto is used during building | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Pacho Ramos <pacho> |
Component: | Core | Assignee: | Portage team <dev-portage> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | itumaykin+gentoo |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 618550 |
Description
Pacho Ramos
2015-01-17 18:05:13 UTC
We have a _check_build_log function that can be used to search the build log for things like this, inside pym/portage/package/ebuild/doebuild.py. I think we should do it as install-qa-check.d check instead. How about making this the first in-tree gentoo check? Oh wait, we can't ;). The spec doesn't officially give access to the build log, so grepping it is still portage-specific. (In reply to Michał Górny from comment #2) > I think we should do it as install-qa-check.d check instead. How about > making this the first in-tree gentoo check? The nice thing about integrating it into the _check_build_log function is that we only have to read the build log once for all of the checks that it performs. Of course, we could integrate the "-flto" check into install-qa-check.d/90gcc-warnings, since that already reads the build log. (In reply to Michał Górny from comment #3) > Oh wait, we can't ;). The spec doesn't officially give access to the build > log, so grepping it is still portage-specific. Well, we support an in-tree build-log-qa-check.d directory, and ideally it would contain declarative config files, so that multiple checks done in a single pass of the build log. |