Bug 536758 – =net-misc/netifrc-0.3.0 breaks VLAN support

• Product: Gentoo Hosted Projects
• Status: RESOLVED FIXED

[Description Guillaume Castagnino 2015-01-16 10:49:51 UTC]

Here is a sample conf that used to work with netifrc 0.2.4:

config_dummy0="null"
routes_dummy0=""
# VLANs
vlans_dummy0="1 2 3 4"
config_dummy0_1="
192.168.106.254/24
"
config_dummy0_2="192.168.154.254/24"
config_dummy0_3="192.168.100.254/24"
config_dummy0_4="null"



When running this conf with netifrc-0.3.0, I get this:
 * Bringing up interface dummy0
 *   Running preup ...  [ ok ]
 *   Adding VLAN 1 to dummy0
 *   Bringing up interface dummy0.1
 *     Running preup ...
/lib/netifrc/net/bonding.sh: line 27: unset: `slaves_dummy0.1': not a valid identifier
/lib/netifrc/net/bonding.sh: line 30: unset: `primary_dummy0.1': not a valid identifier
/lib/netifrc/net/bonding.sh: line 33: unset: `subsume_dummy0.1': not a valid identifier
modprobe: FATAL: Module bonding not found.
 *     Cannot load the bonding module
 *   Adding VLAN 2 to dummy0
 *   Bringing up interface dummy0.2
 *     Running preup ...
/lib/netifrc/net/bonding.sh: line 27: unset: `slaves_dummy0.2': not a valid identifier
/lib/netifrc/net/bonding.sh: line 30: unset: `primary_dummy0.2': not a valid identifier
/lib/netifrc/net/bonding.sh: line 33: unset: `subsume_dummy0.2': not a valid identifier
modprobe: FATAL: Module bonding not found.
 *     Cannot load the bonding module
 *   Adding VLAN 3 to dummy0
 *   Bringing up interface dummy0.3
 *     Running preup ...
/lib/netifrc/net/bonding.sh: line 27: unset: `slaves_dummy0.3': not a valid identifier
/lib/netifrc/net/bonding.sh: line 30: unset: `primary_dummy0.3': not a valid identifier
/lib/netifrc/net/bonding.sh: line 33: unset: `subsume_dummy0.3': not a valid identifier
modprobe: FATAL: Module bonding not found.
 *     Cannot load the bonding module
 *   Adding VLAN 4 to dummy0
 *   Bringing up interface dummy0.4
 *     Running preup ...
/lib/netifrc/net/bonding.sh: line 27: unset: `slaves_dummy0.4': not a valid identifier
/lib/netifrc/net/bonding.sh: line 30: unset: `primary_dummy0.4': not a valid identifier
/lib/netifrc/net/bonding.sh: line 33: unset: `subsume_dummy0.4': not a valid identifier
modprobe: FATAL: Module bonding not found.
 *     Cannot load the bonding module




After digging a bit into this, it seems that it’s due to the dot in IFVAR (added by vlan numbering) is not replaced by an underscore as it used to be in netifrc-0.2.4

This is quite critical, since it breaks network setup

[Comment 1 Guillaume Castagnino 2015-01-16 11:46:41 UTC]

Found this is because of the shell_var function introduced here https://github.com/gentoo/netifrc/commit/a3444e9abf16ecb6145e95a891433b3a79800170

It’n not working, contrary to the one implemented in /sbin/runscript

[Comment 2 Guillaume Castagnino 2015-01-16 12:01:21 UTC]

And here is the fix: https://github.com/gentoo/netifrc/pull/8

Hopefully not hard to fix

[Comment 3 Tino Mueller 2015-01-19 06:52:22 UTC]

Had the same problem.
Proposed fix helped.
Thanks for that.

[Comment 4 Jonathan Thibault 2015-01-19 16:59:16 UTC]

Same problem here.  Downgraded to 0.2.4 as a workaround.  Hopefully fix will be merged in soon.

[Comment 5 Guillaume Castagnino 2015-02-01 06:19:36 UTC]

It was already bumped