| Summary: | net-misc/tor-0.2.6.2_alpha - USE=systemd tries to link to -lsystemd-daemon instead of -lsystemd | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Anthony Basile <blueness> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | eugene.shalygin, systemd, tetromino |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Build log .gz
tor with fixed systemd patch - local portage archive |
||
They also fail to support --disable-systemd.
[case "${enableval}" in
yes) systemd=true ;;
no) systemd=false ;;
* ) AC_MSG_ERROR(bad value for --enable-systemd) ;;
but...
if test x$enable_systemd = xfalse ; then
have_systemd=no;
else
PKG_CHECK_MODULES(SYSTEMD,
[libsystemd-daemon],
have_systemd=yes,
have_systemd=no)
fi
(note different variables used)
And while at it, please also fix it to support 'libsystemd' pkg-config module :P. Upstream is supposed to have fixed this: https://gitweb.torproject.org/tor.git/commit/?id=fcc78e5f8a3249eadfea31db1aca6884b31c1873 It was reported in bug #534246. But looking at it now, it looks wrong. Created attachment 394392 [details]
tor with fixed systemd patch - local portage archive
For those who cannot wait for this to be fixed in portage or
are annoyed about world update skipping,
I just put it all together and installed it locally.
(In reply to Tom-Steve Watzke from comment #4) > Created attachment 394392 [details] > tor with fixed systemd patch - local portage archive > > For those who cannot wait for this to be fixed in portage or > are annoyed about world update skipping, > I just put it all together and installed it locally. Please don't post tarballs like that. Just upload the patch. Users can then place it in /etc/portage/patches/net-misc/tor and let epatch_user do its magic. Having said that, this is an alpha. I only put it in the tree for testing with the expectation that we will collect breakage for upstream for the next release. I really don't recommend its use in the wild. Finally, that patch is wrong and needs to be rewritten. The upstream code here is in flux, and last I looked at it --disable-systemd was broken. I fixed that and they merged, so hopefully the next release will be good. https://trac.torproject.org/projects/tor/ticket/14350 I've p.masked this for now. I'm not backporting patches for the alpha. |
Created attachment 393600 [details] Build log .gz /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lsystemd-daemon collect2: error: ld returned 1 exit status In other words, they do: PKG_CHECK_MODULES(SYSTEMD, [libsystemd-daemon], have_systemd=yes, have_systemd=no) and then... TOR_SYSTEMD_LIBS="-lsystemd-daemon" like they couldn't just use whatever pkg-config found...