Summary: | mail-filter/opendkim - multi-instance has broken stop routine | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christian Roessner <c> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | net-mail+disabled |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Christian Roessner
2015-01-09 23:44:00 UTC
I am just testing this: stop() { check_cfg || return 1 ebegin "Stopping OpenDKIM" # start-stop-daemon --stop --pidfile "${PIDFILE}" kill -15 $(< ${PIDFILE}) 2>/dev/null eend $? } First tests seem do work. But I want to give it some more time. I report back next week The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28706fe998d7ea18549d78aa1bfee4da6bb18ffa commit 28706fe998d7ea18549d78aa1bfee4da6bb18ffa Author: Michael Orlitzky <mjo@gentoo.org> AuthorDate: 2019-03-27 15:48:17 +0000 Commit: Michael Orlitzky <mjo@gentoo.org> CommitDate: 2019-03-27 17:18:07 +0000 mail-filter/opendkim: new revision to overhaul service scripts. The OpenRC service script has been largely rewritten in this revision, to solve a number of problems: * The PID file is now stored securely (bug 629914). * Different PID files are used for multiple instances (bug 536162). * The detection of boolean options in the config file is more robust, allowing "1", "0", "yes", "false", et cetera. * The socket is now located in a conf.d file, rather than parsed from the config file. The service script ensures that the directory containing the socket has the correct permissions, and the conf.d file comes with a big warning to that effect. Note that the (commented- out) example directory IS NOT shared with the PID file. * An error is thrown if we can't remove a stale socket. * Modern OpenRC service script standards have been adopted. Some minor changes have been made to the systemd service for consistency, but none of them have been tested. More work needs to be done here anyway; for example, we most likely want a tmpfiles.d entry for the local socket directory if the user configures one. This should be documented in opendkim.service.conf, and tested by someone who uses systemd. Closes: https://bugs.gentoo.org/536162 Bug: https://bugs.gentoo.org/629914 Signed-off-by: Michael Orlitzky <mjo@gentoo.org> Package-Manager: Portage-2.3.62, Repoman-2.3.11 .../{opendkim-r2.service => opendkim-r3.service} | 2 +- mail-filter/opendkim/files/opendkim.confd | 18 ++++++ mail-filter/opendkim/files/opendkim.init.r4 | 55 ---------------- mail-filter/opendkim/files/opendkim.init.r5 | 73 ++++++++++++++++++++++ mail-filter/opendkim/files/opendkim.service.conf | 2 + ...-2.10.3-r6.ebuild => opendkim-2.10.3-r7.ebuild} | 26 ++++---- 6 files changed, 109 insertions(+), 67 deletions(-) |