Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 53610

Summary: kernel-2.eclass: unipatch should clean up ${WORKDIR}/patches if called more than once
Product: Gentoo Linux Reporter: Tavin Cole <tavin.cole>
Component: [OLD] Core systemAssignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel>
Status: RESOLVED FIXED    
Severity: minor CC: johnm
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Tavin Cole 2004-06-10 22:11:21 UTC
unipatch leaves patch files laying about in ${WORKDIR}/patches.  if you call it more than once from the ebuild it tries to reapply all the patches from the previous call(s), which of course fails and stops the emerge.  i need to call it more than once so i can do other things in between patches (e.g. rm'ing certain files).

Reproducible: Always
Steps to Reproduce:
1. unipatch /path/to/patch1
2. unipatch /path/to/patch2
3. Kaboom!
Comment 1 John Mylchreest (RETIRED) gentoo-dev 2004-08-25 15:12:20 UTC
ideally this shouldn't really be the practice for using unipatch.
this functionality however has now been added.
where possible, the patchset should just be modified to be sane before patching begins.

should hit portage in the next commit (later tonight)
Comment 2 Tavin Cole 2004-08-31 19:40:27 UTC
well, i've been making heavily customized kernel ebuilds with patches gathered from various sources, and it's just easier to call unipatch multiple times.  these aren't for the general public ;)

thank you!