Bug 536002 – net-misc/networkmanager-0.9.10.1_pre20141101 missing dependency: ppp? ( net-dialup/rp-pppoe )

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Malte Starostik 2015-01-08 09:14:08 UTC]

With commit 7955806a02db64b20079267743056d7d9d45af3b, NetworkManager switched from kernel PPPoE to userspace via rp-pppoe for the time being.
Thus for such connection (e.g. ADSL) net-dialup/rp-pppoe is needed.

Reproducible: Always

Steps to Reproduce:
1. Install/upgrade to current stable NetworkManager
2. Try to initiate a PPPoE connection

Actual Results:  
Impossible to connect to the internet (kinda bad if that is where one could subsequently download rp-pppoe from).
This is a regression after upgrading from 0.9.8.10-r1

Jan 07 21:01:59 habanero NetworkManager[664]: <info>  (enp0s18f2u1i1): device state change: config -> ip-config (reason 'none') [50 70 0]
Jan 07 21:01:59 habanero NetworkManager[664]: <warn>  (enp0s18f2u1i1): PPPoE failed to start: Could not find pppoe binary.
Jan 07 21:01:59 habanero NetworkManager[664]: <info>  (enp0s18f2u1i1): device state change: ip-config -> failed (reason 'ppp-start-failed') [70 120 12]
Jan 07 21:01:59 habanero NetworkManager[664]: <warn>  Activation (enp0s18f2u1i1) failed for connection 'isp'


Expected Results:  
Get online

7955806a02db64b20079267743056d7d9d45af3b says:

ppp-manager: don't use kernel pppoe (rh #1034860, rh #1061641)
The kernel PPPoE code disconnects when it receives a PADT frame, but doesn't notify userland about it. So if the server sends a PPPoE PADT without having sent the standard PPP LCP Termination request first, then pppd (and thus NetworkManager) will not know that the connection has been disconnected. This should eventually be fixed in the kernel, but for now, work around this by using the userland pppoe client rather than the kernel code.

[Comment 1 Malte Starostik 2015-01-08 09:22:54 UTC]

Thinking about it, this is surely not needed for everyone who just wants plain PPP to work. So maybe better wrap it in another USE flag or at least notify the user about it.
Hope I didn't set the priority too high, but as this easily affects the ability to fix it after the fact when the connection is crucial for further installations... As an additional pain the prior version 0.9.8.10-r1 that used to work before the upgrade now consistently segfaults on startup after downgrading again with no config change.

[Comment 2 Pacho Ramos 2015-01-08 10:03:44 UTC]

I think it's better to include it to not let people to have half working setups as yours (and also to follow the same upstream logic when they added this)

[Comment 3 Pacho Ramos 2015-01-08 10:05:18 UTC]

+  08 Jan 2015; Pacho Ramos <[e-mail]>
+  networkmanager-0.9.10.1_pre20141101.ebuild:
+  net-dialup/rp-pppoe is needed by upstream to workaround a kernel problem
+  (#536002 by Malte Starostik)
+

[Comment 4 Nikoli 2015-06-07 15:11:10 UTC]

Upstream reverted this change, please revert in ebuilds too:
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/src/ppp-manager/nm-ppp-manager.c?id=6fdfb03107138e96e641d12a7c4df5ecfacb5406

[Comment 5 Nikoli 2015-06-07 15:12:58 UTC]

See also https://bugzilla.gnome.org/show_bug.cgi?id=742939

[Comment 6 Pacho Ramos 2015-06-07 18:56:39 UTC]

I will wait until a new NM release including this reversion is released as maybe they re-revert it... or re-fix it again and again or... :S

Anyway, what kernel version is the one including that commit fixing their pppoe?

[Comment 7 Nikoli 2015-06-07 20:06:09 UTC]

Do you mean this commit?
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=287f3a943fef58c5c73e42545169443be379222f

It is in master branch only, even 4.0.5 does not have it.

[Comment 8 Pacho Ramos 2015-06-07 20:57:13 UTC]

OK, thanks for the info

[Comment 9 Pacho Ramos 2016-07-07 18:56:36 UTC]

solved by upstream in 1.2