Bug 53487

Summary:	panotools-2.6 ebuild should depend on jdk and properly set include path
Product:	Gentoo Linux	Reporter:	Alexandre Rostovtsev (RETIRED) <tetromino>
Component:	[OLD] Library	Assignee:	Luca Barbato <lu_zero>
Status:	VERIFIED FIXED
Severity:	major	CC:	sbriesen
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	67041
Attachments:	better panotools ebuild

Description Alexandre Rostovtsev (RETIRED) gentoo-dev

2004-06-10 00:10:06 UTC

panotools-2.6 requires jni.h to build, which, as far as I know, only occurs in jdk. Furthermore, the ebuild should add an include path to the CFLAGS to make the makefile look for jni.h (and jni_md.h, at least for sun's jdk) because they are usually all the way in /opt/..., not a very default header location.

Reproducible: Always
Steps to Reproduce:
1. (start with a normal gentoo system. jdk may or may not be installed)
2. ACCEPT_KEYWORDS=~x86 emerge panotools


Actual Results:  
In file included from ptpicker.c:2:
ptutils.h:2:17: jni.h: No such file or directory
[ ... many lines of errors ... ]
ptpicker.c:1192: error: `jreg' undeclared (first use in this function)
ptpicker.c:1193: error: `jseek' undeclared (first use in this function)
make: *** [ptpicker.o] Error 1
make: *** Waiting for unfinished jobs....
 
!!! ERROR: media-libs/panotools-2.6 failed.
!!! Function src_compile, Line 35, Exitcode 2
!!! (no error message)

Expected Results:  
successful emerge

Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev

2004-06-10 00:15:50 UTC

Created attachment 33009 [details]
better panotools ebuild

This ebuild works for me (I use sun-jdk-1.4.2.04). Note that renaming this into
panotools-2.6-r1 will break the ebuild (the patch filename depends on $PV) or
force whoever is making those patches into changing his patch naming
convention.

Comment 2 Luca Barbato gentoo-dev

2004-06-10 09:02:32 UTC

that java dependency is insane, I'll try to remove that IF the applications relying on panotools aren't using it and java isn't set on USE.

Comment 3 Kevin O'Rourke 2004-07-03 09:04:24 UTC

The 'better panotools ebuild' works well for me too.

Comment 4 Martin Allchin 2004-09-06 03:38:18 UTC

Doesn't work for me, I am using amd64 :(

I get this:

Calculating dependencies ...done!
>>> emerge (1 of 1) media-libs/panotools-2.6 to /
>>> md5 src_uri ;-) panotools-2.6.tar.bz2
>>> md5 src_uri ;-) panotools-2.6-patches-r0.patch.bz2
>>> Unpacking source...
>>> Unpacking panotools-2.6.tar.bz2 to /var/tmp/portage/panotools-2.6/work
 * Applying panotools-2.6-patches-r0.patch.bz2...                         [ ok ]
>>> Source unpacked.
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o filter.o filter.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o parser.o parser.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o correct.o correct.c
correct.c: In function `ShiftImage':
correct.c:647: warning: use of cast expressions as lvalues is deprecated
correct.c:647: warning: use of cast expressions as lvalues is deprecated
correct.c:649: warning: use of cast expressions as lvalues is deprecated
correct.c:649: warning: use of cast expressions as lvalues is deprecated
correct.c:650: warning: use of cast expressions as lvalues is deprecated
correct.c:650: warning: use of cast expressions as lvalues is deprecated
correct.c:651: warning: use of cast expressions as lvalues is deprecated
correct.c:651: warning: use of cast expressions as lvalues is deprecated
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o perspect.o perspect.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o adjust.o adjust.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o remap.o remap.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o lmdif.o lmdif.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o file.o file.c
file.c:109:27: warning: multi-character character constant
file.c:168:27: warning: multi-character character constant
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o math.o math.c
file.c:790:26: warning: multi-character character constant
file.c:791:26: warning: multi-character character constant
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o pan.o pan.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o PTDialogs.o PTDialogs.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o fftn.o fftn.c
file.c:1455:34: warning: multi-character character constant
file.c:1456:34: warning: multi-character character constant
file.c:1504:26: warning: multi-character character constant
file.c:1505:26: warning: multi-character character constant
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o fourier.o fourier.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o resample.o resample.c
resample.c: In function `nn_16':
resample.c:455: warning: use of cast expressions as lvalues is deprecated
resample.c:455: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `bil_16':
resample.c:461: warning: use of cast expressions as lvalues is deprecated
resample.c:461: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `poly3_16':
resample.c:469: warning: use of cast expressions as lvalues is deprecated
resample.c:469: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `spline16_16':
resample.c:476: warning: use of cast expressions as lvalues is deprecated
resample.c:476: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `spline36_16':
resample.c:483: warning: use of cast expressions as lvalues is deprecated
resample.c:483: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `spline64_16':
resample.c:489: warning: use of cast expressions as lvalues is deprecated
resample.c:489: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `sinc256_16':
resample.c:497: warning: use of cast expressions as lvalues is deprecated
resample.c:497: warning: use of cast expressions as lvalues is deprecated
resample.c: In function `sinc1024_16':
resample.c:505: warning: use of cast expressions as lvalues is deprecated
resample.c:505: warning: use of cast expressions as lvalues is deprecated
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o optimize.o optimize.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o morpher.o morpher.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o Triangulate.o Triangulate.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o seamer.o seamer.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o ptpicker.o ptpicker.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o pteditor.o pteditor.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o tiff.o tiff.c
tiff.c: In function `readtif':
tiff.c:67: warning: passing arg 4 of `TIFFReadRGBAImage' from incompatible point er type
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o jpeg.o jpeg.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o png.o png.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o multilayer.o multilayer.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o sys_ansi.o sys_ansi.c
gcc -O3 -pipe -ftracer -I/opt/blackdown-jdk-1.4.2_rc1/include -I/opt/blackdown-j dk-1.4.2_rc1/include/linux -D__Ansi__=1   -c -o ppm.o ppm.c
gcc -lm -ljpeg -ltiff -lpng -shared -o libpano12.so filter.o parser.o  correct.o  perspect.o adjust.o  remap.o lmdif.o  file.o math.o pan.o PTDialogs.o fftn.o fo urier.o resample.o optimize.o morpher.o Triangulate.o seamer.o ptpicker.o ptedit or.o tiff.o jpeg.o png.o multilayer.o  sys_ansi.o ppm.o
/usr/lib/gcc-lib/x86_64-pc-linux-gnu/3.3.4/../../../../x86_64-pc-linux-gnu/bin/l d: filter.o: relocation R_X86_64_32 can not be used when making a shared object;  recompile with -fPIC
filter.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
make: *** [libpano12.so] Error 1

!!! ERROR: media-libs/panotools-2.6 failed.
!!! Function src_compile, Line 38, Exitcode 2
!!! (no error message)

Comment 5 Luca Barbato gentoo-dev

2004-11-26 12:50:30 UTC

I'm about to hardmask that ebuild and then update to the new libpano12 and tools from panotools.sf.net

Comment 6 David Grant 2005-01-03 12:56:39 UTC

I am pretty sure this bug can be closed now.

Comment 7 Luca Barbato gentoo-dev

2005-01-03 18:07:05 UTC

Resolved as Fixed

Comment 8 Luca Barbato gentoo-dev

2005-01-03 18:07:20 UTC

Closing