Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 534786

Summary: media-gfx/splashutils - re-add USE=mng
Product: Gentoo Linux Reporter: i.Dark_Templar <idarktemplar>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED OBSOLETE    
Severity: normal CC: idarktemplar, jstein, scott, treecleaner
Priority: Normal Keywords: PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=526834
Whiteboard: Pending removal: 2018-11-21
Package list:
Runtime testing required: ---
Bug Depends on: 499654, 534784    
Bug Blocks:    

Description i.Dark_Templar 2015-01-05 16:10:32 UTC
Splashutils does not directly depend on lcms. It depends on libmng, which in turn depends on lcms. The only reason the dependency was direct, AFAIK, is that libmng does not ensure availability of static libs of lcms it depends on when you request static libs of libmng.

https://bugs.gentoo.org/show_bug.cgi?id=534784

And libmng already links to lcms:2, so there is no reason to drop mng support in splashutils.

Reproducible: Always
Comment 1 i.Dark_Templar 2015-01-05 16:11:15 UTC
Ebuild update:

--- /usr/portage/media-gfx/splashutils/splashutils-1.5.4.4-r4.ebuild    2014-12-31 01:31:11.000000000 +0300
+++ /usr/local/portage/media-gfx/splashutils/splashutils-1.5.4.4-r4.ebuild      2015-01-05 17:54:58.000000000 +0300
@@ -47,6 +47,9 @@
                >=media-libs/libpng-1.4.3[static-libs]
                sys-libs/zlib[static-libs(+)]
        )
+       mng? (
+               media-libs/libmng[static-libs(+)]
+       )
        virtual/jpeg:0[static-libs]
        app-arch/cpio
        media-gfx/fbgrab
Comment 2 i.Dark_Templar 2015-01-05 16:35:00 UTC
Missed some of changes, here are all relevant changes reverted and fixed:

--- /usr/portage/media-gfx/splashutils/splashutils-1.5.4.4-r4.ebuild    2014-12-31 01:31:11.000000000 +0300
+++ /usr/local/portage/media-gfx/splashutils/splashutils-1.5.4.4-r4.ebuild      2015-01-05 17:54:58.000000000 +0300
@@ -18,7 +18,7 @@
 FT2SRC="libs/freetype-${V_FT}"
 
 RESTRICT="test"
-IUSE="hardened +png +truetype gpm fbcondecor"
+IUSE="hardened +png +truetype +mng gpm fbcondecor"
 
 DESCRIPTION="Framebuffer splash utilities"
 HOMEPAGE="http://fbsplash.berlios.de"
@@ -47,6 +47,9 @@
                >=media-libs/libpng-1.4.3[static-libs]
                sys-libs/zlib[static-libs(+)]
        )
+       mng? (
+               media-libs/libmng[static-libs(+)]
+       )
        virtual/jpeg:0[static-libs]
        app-arch/cpio
        media-gfx/fbgrab
@@ -93,6 +102,7 @@
 
        epatch "${FILESDIR}/${P}-bzip2.patch"
        epatch "${FILESDIR}/${P}-multi-keyboard.patch"
+       epatch "${FILESDIR}/libmng2-lcms2.patch"
 
        if ! tc-is-cross-compiler && \
           has_version "sys-devel/gcc:$(gcc-version)[vanilla]" ; then
@@ -125,7 +135,7 @@
        cd "${S}"
        econf \
                $(use_with png) \
-               --without-mng \
+               $(use_with mng) \
                $(use_with gpm) \
                $(use_with truetype ttf) \
                $(use_with truetype ttf-kernel) \
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-28 13:19:57 UTC
Package removed.