Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 533884

Summary: sys-apps/portage: --autounmask-write uses EROOT instead of PORTAGE_CONFIGROOT for evaluation of CONFIG_PROTECT
Product: Portage Development Reporter: Zac Medico <zmedico>
Component: Core - Interface (emerge)Assignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal CC: esigra
Priority: Normal Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 137867, 376695, 484436    

Description Zac Medico gentoo-dev 2014-12-29 01:13:11 UTC
While reviewing the --autounmask-write code (due to bug 533648), I found that it uses EROOT instead of PORTAGE_CONFIGROOT when constructing ConfigProtect objects. The result is that CONFIG_PROTECT handling can misbehave when using PORTAGE_CONFIGROOT. The offending line that should use PORTAGE_CONFIGROOT instead of EROOT looks like this:

	protect_obj[root] = ConfigProtect(settings["EROOT"], \
Comment 1 Zac Medico gentoo-dev 2014-12-29 01:29:51 UTC
I've posted a patch for review here:

	http://thread.gmane.org/gmane.linux.gentoo.portage.devel/5048
Comment 2 Zac Medico gentoo-dev 2015-01-05 19:56:01 UTC
This is in the master branch:

https://github.com/gentoo/portage/commit/417fc75190eb70836de9856f35c8141cacfd49fb
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2015-03-04 21:26:01 UTC
Released in portage-2.2.16