Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 533460

Summary: repoman gives wrong warnings about invalid copyright header
Product: Portage Development Reporter: Julian Ospald <hasufell>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED WONTFIX    
Severity: normal CC: bugzilla-gentoo, erikdenstore+gbugs, mrueg, wtt6
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Julian Ospald 2014-12-24 15:21:06 UTC
Any copyright header that does not say

# Copyright <years> Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: [random string] $

is wrong to repoman. Does that mean anyone running an overlay is expected to give copyright to gentoo foundation?
Comment 1 Zac Medico gentoo-dev 2014-12-24 16:31:20 UTC
We really need to provide a way for the repository to disable specific repoman checks, using either metadata/layout.conf or a new config file included in the repository.
Comment 2 Julian Ospald 2014-12-24 16:36:24 UTC
I'd say a new config file makes more sense, because disabling repoman warnings doesn't change the repository layout.
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2014-12-24 17:57:08 UTC
In addition disabling repoman checks in package's metadata.xml, would be nice, too. 
So we could easily mask false positives, without adding too much complexity to the repoman checks.
Comment 4 Julian Ospald 2014-12-24 18:14:50 UTC
(In reply to Manuel Rüger from comment #3)
> In addition disabling repoman checks in package's metadata.xml, would be
> nice, too. 
> So we could easily mask false positives, without adding too much complexity
> to the repoman checks.

Same here... disabling repoman checks doesn't change the metadata of an ebuild and shouldn't be there.

We can make a config file that accepts package specific syntax.
Comment 5 Zac Medico gentoo-dev 2014-12-24 18:22:48 UTC
(In reply to Manuel Rüger from comment #3)
> In addition disabling repoman checks in package's metadata.xml, would be
> nice, too. 

FWIW, you can disable some warnings by adding #nowarn to the end of the line that triggers the warning:

https://github.com/gentoo/portage/commit/de51993645f9656dfa8a74f6bf9cc85ed56ee8fa
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:38 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.