Summary: | sys-apps/portage: improve initial git sync message | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Michał Górny <mgorny> |
Component: | Unclassified | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | moonlapse81 |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://article.gmane.org/gmane.linux.gentoo.portage.devel/5089 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
The first line of message could depend on existence of repository: >>> Synchronization of repository '${name}' to be located in '${location}'... >>> Synchronization of repository '${name}' located in '${location}'... >>> Synchronizing repository '${name}' to '${location}'...
Simpler and seems to cover both cases.
looks better :) as all of these message make no real sense because portage tree not exist yet In review: http://article.gmane.org/gmane.linux.gentoo.portage.devel/5089 The result being: >>> Syncing repository 'sunrise' into '/var/db/repos/sunrise'... /usr/bin/git pull Already up-to-date. === Sync completed for sunrise Plus the one for the extra git noise: http://article.gmane.org/gmane.linux.gentoo.portage.devel/5087 commit e6777b92a3c4aa1d23ccb868146a71336b29cf8a Author: Michał Górny <mgorny@gentoo.org> Date: Sat Jan 17 14:29:30 2015 +0100 sync: unify syncing messages and reduce noise Print single ">>> Syncing repository '%s' into '%s'..." before syncing, and single "=== Sync completed for %s" after successful sync. Remove duplicate in-module clone/pull messages. Instead, verbosely print git commands executed. Remove useless verbosity in pre-sync mkdir. |
>>> Synchronization of repository 'gentoo' located in '/var/db/repositories/funtoo'... >>> '/var/db/repositories/funtoo' not found, creating it.fatal: Not a git repository (or any of the parent directories): .git >>> Cloning git repository from upstream into /var/db/repositories/funtoo... Looks like we should at least silence that git error output. We could also try to get the no of messages down.