Bug 533094

Summary:	games-util/pyfa-9999 - install: cannot stat ‘readme.txt’: No such file or directory
Product:	Gentoo Linux	Reporter:	Martin McCourt <martinlmccourt>
Component:	[OLD] Games	Assignee:	Alexandre Rostovtsev (RETIRED) <tetromino>
Status:	RESOLVED FIXED
Severity:	normal	CC:	martinlmccourt
Priority:	Normal
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	pyfa-9999.ebuild

Description Martin McCourt 2014-12-20 06:17:59 UTC

It seems that the name and location of the dodoc object has changed in the GIT repository for this package from readme.txt to staticdata/README.txt

Reproducible: Always

Steps to Reproduce:
1. echo "=games-util/pyfa-9999 **" >> /etc/portage/package.keywords
2. emerge -v games-util/pyfa


Actual Results:  
# emerge -va pyfa

These are the packages that would be merged, in order:
*snip*
>>> Install pyfa-9999 into /var/tmp/portage/games-util/pyfa-9999/image/ category games-util
 * python2_7: running pyfa_py_install
install: cannot stat ‘readme.txt’: No such file or directory
!!! dodoc: readme.txt does not exist
 * ERROR: games-util/pyfa-9999::gentoo failed (install phase):
 *   dodoc failed
 * 
 * If you need support, post the output of `emerge --info '=games-util/pyfa-9999::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=games-util/pyfa-9999::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/games-util/pyfa-9999/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/games-util/pyfa-9999/temp/environment'.
 * Working directory: '/var/tmp/portage/games-util/pyfa-9999/work/pyfa'
 * S: '/var/tmp/portage/games-util/pyfa-9999/work/pyfa'
 * QA Notice: file does not exist:
 * 
 *      dodoc: readme.txt does not exist

>>> Failed to emerge games-util/pyfa-9999, Log file:
*snip*

Expected Results:  
marty ~ # emerge -va pyfa

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   *] games-util/pyfa-9999  USE="graph" PYTHON_TARGETS="python2_7" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] yes

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) games-util/pyfa-9999::gentoo
>>> Unpacking source...
GIT update -->
   repository:               https://github.com/DarkFenX/Pyfa.git
   at the commit:            71bf1556a1cb0b6c32afadd326ffd46873d941f9
   branch:                   master
   storage directory:        "/usr/portage/distfiles/egit-src/Pyfa.git"
   checkout type:            bare repository
Cloning into '/var/tmp/portage/games-util/pyfa-9999/work/pyfa'...
done.
Branch branch-master set up to track remote branch master from origin.
Switched to a new branch 'branch-master'
>>> Unpacked to /var/tmp/portage/games-util/pyfa-9999/work/pyfa
>>> Source unpacked in /var/tmp/portage/games-util/pyfa-9999/work
>>> Preparing source in /var/tmp/portage/games-util/pyfa-9999/work/pyfa ...
 * Applying pyfa-1.1.20-staticPath.patch ...                                                 [ ok ]
 * Applying pyfa-1.1.8-html-export-path.patch ...                                            [ ok ]
 * Applying pyfa-1.1.11-import-pyfa.patch ...                                                [ ok ]
 * python2_7: running pyfa_make_configforced
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/games-util/pyfa-9999/work/pyfa ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/games-util/pyfa-9999/work/pyfa ...
>>> Source compiled.
>>> Test phase [not enabled]: games-util/pyfa-9999

>>> Install pyfa-9999 into /var/tmp/portage/games-util/pyfa-9999/image/ category games-util
 * python2_7: running pyfa_py_install
>>> Completed installing pyfa-9999 into /var/tmp/portage/games-util/pyfa-9999/image/

ecompressdir: bzip2 -9 /usr/share/doc

>>> Installing (1 of 1) games-util/pyfa-9999::gentoo
 * checking 6318 files for package collisions

*snip*

>>> Original instance of package unmerged safely.
 * Updating icons cache ...                                                                  [ ok ]
>>> games-util/pyfa-9999 merged.
>>> Auto-cleaning packages...

>>> No outdated packages were found on your system.

 * GNU info directory index is up-to-date.
marty ~ # 


# emerge -pqv '=games-util/pyfa-9999::gentoo'
[ebuild   R   ] games-util/pyfa-9999  USE="graph" PYTHON_TARGETS="python2_7" 
# cat /var/tmp/portage/games-util/pyfa-9999/temp/build.log
 * Package:    games-util/pyfa-9999
 * Repository: gentoo
 * Maintainer: tetromino@gentoo.org
 * USE:        abi_x86_64 amd64 elibc_glibc graph kernel_linux python_targets_python2_7 userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
GIT update -->
   repository:               https://github.com/DarkFenX/Pyfa.git
   at the commit:            71bf1556a1cb0b6c32afadd326ffd46873d941f9
   branch:                   master
   storage directory:        "/usr/portage/distfiles/egit-src/Pyfa.git"
   checkout type:            bare repository
Cloning into '/var/tmp/portage/games-util/pyfa-9999/work/pyfa'...
done.
Branch branch-master set up to track remote branch master from origin.
Switched to a new branch 'branch-master'
>>> Unpacked to /var/tmp/portage/games-util/pyfa-9999/work/pyfa
>>> Source unpacked in /var/tmp/portage/games-util/pyfa-9999/work
>>> Preparing source in /var/tmp/portage/games-util/pyfa-9999/work/pyfa ...
 * Applying pyfa-1.1.20-staticPath.patch ...                                                 [ ok ]
 * Applying pyfa-1.1.8-html-export-path.patch ...                                            [ ok ]
 * Applying pyfa-1.1.11-import-pyfa.patch ...                                                [ ok ]
 * python2_7: running pyfa_make_configforced
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/games-util/pyfa-9999/work/pyfa ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/games-util/pyfa-9999/work/pyfa ...
>>> Source compiled.
>>> Test phase [not enabled]: games-util/pyfa-9999

>>> Install pyfa-9999 into /var/tmp/portage/games-util/pyfa-9999/image/ category games-util
 * python2_7: running pyfa_py_install
install: cannot stat ‘readme.txt’: No such file or directory
!!! dodoc: readme.txt does not exist
 * ERROR: games-util/pyfa-9999::gentoo failed (install phase):
 *   dodoc failed
 * 
 * If you need support, post the output of `emerge --info '=games-util/pyfa-9999::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=games-util/pyfa-9999::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/games-util/pyfa-9999/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/games-util/pyfa-9999/temp/environment'.
 * Working directory: '/var/tmp/portage/games-util/pyfa-9999/work/pyfa'
 * S: '/var/tmp/portage/games-util/pyfa-9999/work/pyfa'
 * QA Notice: file does not exist:
 * 
 *      dodoc: readme.txt does not exist
#


The following patch to the ebuild fixes the problem and allows the package to be merged successfully after it is re-digested:
--- pyfa-9999.ebuild    2014-06-04 10:01:19.000000000 -0400
+++ pyfa-9999.ebuild-fixed      2014-12-20 00:39:58.000000000 -0500
@@ -72,7 +72,7 @@
 
        insinto /usr/share/${PN}
        doins -r staticdata
-       dodoc readme.txt
+       dodoc staticdata/README.txt
        insinto /usr/share/icons/hicolor/32x32/apps
        doins icons/pyfa.png
        insinto /usr/share/icons/hicolor/64x64/apps

Comment 1 Martin McCourt 2014-12-20 06:25:35 UTC

Created attachment 392070 [details]
pyfa-9999.ebuild

The patch that could be applied is below:
--- pyfa-9999.ebuild-old    2014-06-04 10:01:19.000000000 -0400
+++ pyfa-9999.ebuild        2014-12-20 00:39:58.000000000 -0500
@@ -72,7 +72,7 @@
 
        insinto /usr/share/${PN}
        doins -r staticdata
-       dodoc readme.txt
+       dodoc staticdata/README.txt
        insinto /usr/share/icons/hicolor/32x32/apps
        doins icons/pyfa.png
        insinto /usr/share/icons/hicolor/64x64/apps

# followed up with a ebuild /usr/portage/games-util/pyfa/pyfa-9999.ebuild digest works wonders

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2014-12-20 06:54:56 UTC

Comment on attachment 392070 [details]
pyfa-9999.ebuild

--- pyfa-9999.ebuild
+++ pyfa-9999.ebuild
@@ -72,7 +72,7 @@

        insinto /usr/share/${PN}
        doins -r staticdata
-       dodoc readme.txt
+       dodoc staticdata/README.txt
        insinto /usr/share/icons/hicolor/32x32/apps
        doins icons/pyfa.png
        insinto /usr/share/icons/hicolor/64x64/apps

Comment 3 Martin McCourt 2015-02-02 23:30:15 UTC

the patched ebuild isn't showing up when I sync - is there anything I can do to help push this along :)?

Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev

2015-02-17 22:37:41 UTC

Fixed, thanks!

+*pyfa-1.8.1 (17 Feb 2015)
+
+  17 Feb 2015; Alexandre Rostovtsev <tetromino@gentoo.org> -pyfa-1.2.0.ebuild,
+  -pyfa-1.2.1.ebuild, +pyfa-1.8.1.ebuild, pyfa-9999.ebuild:
+  Very late version bump for Proteus (bug #519416, tthanks to Hedin Ejdesgaard
+  Møller, Stefan Reimer et al); fix missing dep (bug #505192, thanks to Nick
+  Wallingford) and new readme location (bug #533094, thanks to Martin McCourt).