Bug 532842 – www-apache/mod_mono: port to apache2.4

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Pacho Ramos 2014-12-17 14:21:29 UTC]

http://download.opensuse.org/source/factory/repo/oss/suse/src/apache2-mod_mono-2.10-17.1.src.rpm

opensuse has the needed patches for that

Thanks

[Comment 1 Gerald 2015-01-07 06:56:50 UTC]

Need this too...

[Comment 2 Pacho Ramos 2015-05-09 11:29:51 UTC]

Created attachment 402888 [details, diff]
1.patch

[Comment 3 Pacho Ramos 2015-05-09 11:30:10 UTC]

Created attachment 402890 [details]
error.log

[Comment 4 Pacho Ramos 2015-05-09 11:30:35 UTC]

The patch applies ok with "patch -p1" but fails with epatch !?

[Comment 5 Pacho Ramos 2015-05-09 11:30:57 UTC]

Created attachment 402892 [details]
1.ebuild

The updated ebuild to apply it

[Comment 6 Dirkjan Ochtman (RETIRED) 2015-05-14 23:00:38 UTC]

mod_mono currently advertises support for Apache 2.4.3, at least, so maybe this is just a version bump at this point?

[Comment 7 SpanKY 2015-05-15 03:52:24 UTC]

Comment on attachment 402890 [details]
error.log

looks like you attached the patch again instead of an error log

[Comment 8 Pacho Ramos 2015-05-15 06:26:55 UTC]

Created attachment 403308 [details]
patch.out

[Comment 9 Pacho Ramos 2015-06-03 08:52:48 UTC]

@base-system, do you have any idea about why plain patch (even with the options passed by epatch) works while epatch don't? Thanks :/

[Comment 10 SpanKY 2015-06-07 18:08:47 UTC]

(In reply to Pacho Ramos from comment #9)

makes sense -- epatch first does a dry-run and your patch modifies the same file in the same area but with multiple hunks.  you can make it fail by hand too:

$ patch -p1 < mod_mono-2.10-apache-2.4.patch --dry-run
checking file configure.in
checking file src/mod_mono.c
Hunk #1 succeeded at 386 (offset -2 lines).
Hunk #2 succeeded at 400 (offset -2 lines).
Hunk #3 succeeded at 414 (offset -2 lines).
Hunk #4 succeeded at 497 (offset -2 lines).
Hunk #5 succeeded at 862 (offset -4 lines).
Hunk #6 succeeded at 879 (offset -4 lines).
Hunk #7 succeeded at 1997 (offset -15 lines).
Hunk #8 succeeded at 2049 (offset -15 lines).
checking file src/mod_mono.c
Hunk #1 FAILED at 499.
1 out of 1 hunk FAILED
checking file src/mod_mono.c
Hunk #1 FAILED at 870.
Hunk #2 FAILED at 887.
2 out of 2 hunks FAILED

$ patch -p1 < mod_mono-2.10-apache-2.4.patchpatching file configure.in
patching file src/mod_mono.c
Hunk #1 succeeded at 386 (offset -2 lines).
Hunk #2 succeeded at 400 (offset -2 lines).
Hunk #3 succeeded at 414 (offset -2 lines).
Hunk #4 succeeded at 497 (offset -2 lines).
Hunk #5 succeeded at 862 (offset -4 lines).
Hunk #6 succeeded at 879 (offset -4 lines).
Hunk #7 succeeded at 1997 (offset -15 lines).
Hunk #8 succeeded at 2049 (offset -15 lines).
patching file src/mod_mono.c
Hunk #1 succeeded at 497 (offset -2 lines).
patching file src/mod_mono.c
Hunk #1 succeeded at 866 (offset -4 lines).
Hunk #2 succeeded at 883 (offset -4 lines).

solution is simple: don't do that ;).  if it's three patches, then split it apart and apply it as three patches.  or squash them together by hand into one.

[Comment 11 Pacho Ramos 2015-06-07 19:15:39 UTC]

@vapier, thanks a lot!

+  07 Jun 2015; Pacho Ramos <[e-mail]>
+  +files/mod_mono-2.10-apache-2.4.patch, mod_mono-2.10.ebuild:
+  Support apache 2.4 (#532842)
+