Bug 529926 – dev-python/markupsafe-1.0 fails tests with pypy3

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Paolo Pedroni 2014-11-20 10:32:15 UTC]

Created attachment 389842 [details]
markupsafe-0.23:20141120-102114.log.gz

Since dev-python/markupsafe-0.23 has pypy3 enabled I get the following test failure:

running test
running egg_info
writing /var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-pypy3/build/MarkupSafe.egg-info/PKG-INFO
writing top-level names to /var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-pypy3/build/MarkupSafe.egg-info/top_level.txt
writing dependency_links to /var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-pypy3/build/MarkupSafe.egg-info/dependency_links.t
xt
reading manifest file '/var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-pypy3/build/MarkupSafe.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file '/var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-pypy3/build/MarkupSafe.egg-info/SOURCES.txt'
running build_ext
test_adding (markupsafe.tests.MarkupTestCase) ... ok
test_all_set (markupsafe.tests.MarkupTestCase) ... ok
test_complex_custom_formatting (markupsafe.tests.MarkupTestCase) ... ok
test_custom_formatting (markupsafe.tests.MarkupTestCase) ... ok
test_dict_interpol (markupsafe.tests.MarkupTestCase) ... ok
test_escape_silent (markupsafe.tests.MarkupTestCase) ... ok
test_escaping (markupsafe.tests.MarkupTestCase) ... ok
test_formatting (markupsafe.tests.MarkupTestCase) ... ok
test_formatting_empty (markupsafe.tests.MarkupTestCase) ... ok
test_html_interop (markupsafe.tests.MarkupTestCase) ... ok
test_mul (markupsafe.tests.MarkupTestCase) ... ok
test_splitting (markupsafe.tests.MarkupTestCase) ... ok
test_string_interpolation (markupsafe.tests.MarkupTestCase) ... ok
test_tuple_interpol (markupsafe.tests.MarkupTestCase) ... ok
test_type_behavior (markupsafe.tests.MarkupTestCase) ... ok
test_markup_leaks (markupsafe.tests.MarkupLeakTestCase) ... FAIL

======================================================================
FAIL: test_markup_leaks (markupsafe.tests.MarkupLeakTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-pypy3/markupsafe/tests.py", line 162, in test_markup_leaks
    assert len(counts) == 1, 'ouch, c extension seems to leak objects'
AssertionError: ouch, c extension seems to leak objects

----------------------------------------------------------------------
Ran 16 tests in 4.633s

FAILED (failures=1)

# emerge --info
Portage 2.2.14 (python 3.4.2-final-0, default/linux/amd64/13.0/desktop/kde/systemd, gcc-4.8.3, glibc-2.19-r1, 3.18.0-rc5 x86_64)
=================================================================
System uname: Linux-3.18.0-rc5-x86_64-AMD_Phenom-tm-_II_X6_1100T_Processor-with-gentoo-2.2
KiB Mem:    12027380 total,   1907116 free
KiB Swap:    8643068 total,   8637360 free
Timestamp of tree: Thu, 20 Nov 2014 08:15:01 +0000
ld GNU gold (Gentoo 2.24 p1.4 2.24) 1.11
distcc 3.1 x86_64-pc-linux-gnu [enabled]
ccache version 3.1.9 [disabled]
app-shells/bash:          4.3_p30-r1
dev-java/java-config:     2.2.0
dev-lang/perl:            5.20.1-r2
dev-lang/python:          2.7.7, 3.4.2
dev-util/ccache:          3.1.9-r3
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.69
sys-devel/automake:       1.11.6-r1, 1.13.4
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.16 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=amdfam10 -msahf -mlzcnt -mpopcnt --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -flto=7 -fuse-linker-plugin -floop-interchange -floop-strip-mine -floop-block -fgraphite-identity"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=amdfam10 -msahf -mlzcnt -mpopcnt --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -flto=7 -fuse-linker-plugin -floop-interchange -floop-strip-mine -floop-block -fgraphite-identity"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going y --with-bdeps y"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs compress-build-logs config-protect-if-modified distcc distlocks ebuild-locks merge-sync news parallel-fetch protect-owned sandbox sfperms split-elog split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.halifax.rwth-aachen.de/gentoo/ http://tux.rainside.sk/gentoo/ http://gentoo.mneisen.org/ http://gentoo.tiscali.nl/ http://gentoo.inode.at/"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common -flto=7 -fuse-linker-plugin -floop-interchange -floop-strip-mine -floop-block -fgraphite-identity"
MAKEOPTS="-j12"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow X a52 aac aalib acl acpi adns alsa amd64 ao audiofile bash-completion bluetooth branding bzip2 cairo caps cdda cddb cdparanoia cdr cli cracklib crypt css cups curl cxx dbus declarative dga djvu dri dts dvd dvdr emboss encode exif expat fam fbcon ffmpeg fftw firefox flac fontconfig foomaticdb fortran ftp gd gdbm geoip gif gimp glamor gmp gnutls gphoto2 gpm graphviz gstreamer gtk handbook iconv icu idn ieee1394 imagemagick imlib ipv6 java javascript jbig jpeg jpeg2k kde kipi lame lcms libass libcaca libnotify libsamplerate lm_sensors lua lzma lzo mad mmap mmx mng modules mp3 mp4 mpeg mplayer multilib musicbrainz ncurses nls nptl nsplugin offensive ogg openal openexr opengl openmp pam pango pcre pdf phonon plasma png policykit postscript ppds pulseaudio qt3support qt4 rdesktop readline recode samba scanner sdl semantic-desktop session smartcard sndfile sockets speex spell sqlite sqlite3 sse sse2 ssl startup-notification svg symlink syslog systemd sysvipc taglib theora threads tidy tiff truetype udev udisks unicode upower usb vcd vdpau vim-syntax vnc vorbis wayland win32codecs wmf wxwidgets x264 xattr xcb xcomposite xinerama xml xpm xscreensaver xv xvid yahoo zlib" ABI_X86="64" ALSA_CARDS="hda-intel virmidi" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="kodak ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="nlpsolver" LINGUAS="it" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4 pypy pypy3" RUBY_TARGETS="ruby20" SANE_BACKENDS="epson epson2" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

# emerge -1pqv =dev-python/markupsafe-0.23
[ebuild   R   ] dev-python/markupsafe-0.23  PYTHON_TARGETS="pypy pypy3%* python2_7 python3_4 (-python3_2) -python3_3"

[Comment 1 Paolo Pedroni 2014-11-21 12:33:05 UTC]

This bug, on the other hand, is NOT fixed by rebuilding dev-python/pypy3 without LTO, so I think it warrants some more attention.

[Comment 2 Mike Gilbert 2014-11-21 20:24:05 UTC]

I can reproduce this one.

[Comment 3 Alice Bevan-McGregor 2014-11-21 23:29:42 UTC]

Upstream bug: https://github.com/mitsuhiko/markupsafe/issues/39

[Comment 4 Ian Delaney (RETIRED) 2014-11-22 00:00:47 UTC]

for now leaving ebuild as is. Awaiting this to be addressed by upstream

[Comment 5 Alice Bevan-McGregor 2016-01-13 21:37:30 UTC]

My fix has been accepted upstream.  Unsure if a release is being prepared.

[Comment 6 Justin Lecher (RETIRED) 2016-01-14 08:29:44 UTC]

(In reply to Alice Bevan-McGregor from comment #5)
> My fix has been accepted upstream.  Unsure if a release is being prepared.

Using this patch it fails for python2.7.

test_markup_leaks (markupsafe.tests.MarkupLeakTestCase) ... FAIL

======================================================================
FAIL: test_markup_leaks (markupsafe.tests.MarkupLeakTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/markupsafe-0.23/work/MarkupSafe-0.23-python2_7/markupsafe/tests.py", line 163, in test_markup_leaks
    assert len(counts) == 1, 'ouch, c extension seems to leak objects'
AssertionError: ouch, c extension seems to leak objects

----------------------------------------------------------------------
Ran 16 tests in 0.163s

[Comment 7 Paolo Pedroni 2016-05-17 08:29:00 UTC]

For me it works perfectly with all python versions I have (2.7, 3.4, latest pypy, pypy3). Can we add this patch until upstream releases a new version?

Please.

[Comment 8 Paolo Pedroni 2016-09-28 08:53:07 UTC]

(In reply to Paolo Pedroni from comment #7)
> For me it works perfectly with all python versions I have (2.7, 3.4, latest
> pypy, pypy3). Can we add this patch until upstream releases a new version?

This patch doesn't work anymore. Probably it's because I upgraded to dev-python/pypy3-5.2.0_alpha1, but I don't have time to downgrade and try it out.

[Comment 9 Paolo Pedroni 2017-05-09 08:45:51 UTC]

Now it's started failing with python3.5...

[Comment 10 Wim Muskee 2019-10-22 03:26:08 UTC]

PR available which adds 1.1.1 (with fixed pypy3 test), and removes 1.0: https://github.com/gentoo/gentoo/pull/13094

[Comment 11 Michał Górny 2020-03-27 21:30:02 UTC]

Old version removed.  Please reopen if you can reproduce it with the current one.