Summary: | www-client/midori-0.5.10 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Branko Grubic <bitlord0xff> |
Component: | Current packages | Assignee: | XFCE Team <xfce> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bitlord0xff, bugs, klaus.kusche, lordvan, pacho, v_2e, yura.tsts |
Priority: | Normal | Keywords: | EBUILD, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild_diff
current_diff_to_0.5.10 0.5.8-r1-0.5.10_gcr_fix |
Description
Branko Grubic
2014-11-18 15:59:34 UTC
Created attachment 389634 [details, diff]
ebuild_diff
Yes, removing S=${WORKDIR} entirely seems to work fine, and according to devmanual.gentoo.org is the preferred way of handling this. As you did, I also removed the patch (both the epatch line and the SRC_URI entry). I built with only jit and webkit2 USE flags enabled. Status? Another vote for this one. Created attachment 401658 [details, diff]
current_diff_to_0.5.10
Updated to 0.5.10, this is the diff for current in portage midori-0.5.8-r1.ebuild
I don't know much about build systems, and cmake, but looking at the ChangeLog and CmakeLists.txt
From ChangeLog
"Make GCR mandatory for all builds"
I moved app-crypt/gcr-3 from !deprecated? ( ) so all builds depend on it, for me without app-crypt/gcr-3[vala] it failed at some point with ld errors with undefined reference ( " libmidori-core.so.0.0.0: undefined reference to gcr_certificate_details_widget_new' ") I don't know if [vala] is needed, but if I understand the midori developers/community they are trying to move more and more things to vala code?
Archive is different again, so we need
S=${WORKDIR} again not like in 0.5.9 ebuild diff
Things I didn't check!!!
"Use GNotification >= 2.40 and use Midori.App API in webmedia"
and
"Clean up vapi dependency"
Don't know how important they are and if ebuild need to be changed for those, and if they are related to packaging (both).
I only tested this build config ( www-client/midori-0.5.10 (jit) )
If anyone can test with www-client/midori[deprecated] (gtk2 stuff and different webkit, it would be nice (for me webkit takes too mucht time to build ~3hours)
I'll check if I can change the summary of this bug, if not, devs please change it for midori 0.5.10
(In reply to bitlord from comment #4) ... > I don't know much about build systems, and cmake, but looking at the > ChangeLog and CmakeLists.txt > From ChangeLog > "Make GCR mandatory for all builds" > I moved app-crypt/gcr-3 from !deprecated? ( ) so all builds depend on it, > for me without app-crypt/gcr-3[vala] it failed at some point with ld errors > with undefined reference ( " libmidori-core.so.0.0.0: undefined reference to > gcr_certificate_details_widget_new' ") I don't know if [vala] is needed, but > if I understand the midori developers/community they are trying to move more > and more things to vala code? > app-crypt/gcr-3[vala] is probably not needed, I tested again without USE="vala", looks like it builds fine, need to try with clean system/session again, not sure why it failed before, gcr rebuild possibly fixed it? ... Created attachment 401660 [details, diff]
0.5.8-r1-0.5.10_gcr_fix
not sure what was the problem, I blindly enabled USE="vala" for gcr which fixed the build, but the problem was something else, if someone else test this and it fails with errors like in previous comment, does app-crypt/gcr rebuild fixes it for you?
Not sure if toolchain update can break this, like gcc-4.8.3->4.8.4 update ... or something like that?
(In reply to bitlord from comment #6) .. > Not sure if toolchain update can break this, like gcc-4.8.3->4.8.4 update > ... or something like that? Sorry for spamming too much on this report, looks like it was my fault, I didn't rebuild libtool after gcc upgrade :( (every time you learn something new, not nice when you learn things you skipped before :( 0.5.10 just addded |