Summary: | (PATCH)gnome-terminal poor text selection algorithm implementation leads to poor performance | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | devsk <funtoos> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 59768 | ||
Attachments: | Don't match patterns when not needed |
Description
devsk
2004-06-04 00:32:54 UTC
Created attachment 32625 [details, diff]
Don't match patterns when not needed
this patch is against 2.6.1 any news? i think this patch would be better attended to upstream with the gnome-terminal developers. have you sent this patch to them? yes...report number 122656 http://bugs.gnome.org/show_bug.cgi?id=122656 but it never made it. any news on this patch? it looks good to me.. although i've never seen the described behaviour. I'm not sure what this has todo with CTRL, i guess thats keyboard behaviour i'm not familiar with. Can you give a specific scenario to reproduce this ? Note that with this patch applied i did have a non-reproducable crash, it might be unrelated. OK, the problem is that when you move your mouse around in a g-t, internally it searches for patterns(currently only URL spec, skey) matching the strings under the mouse using regex library. Just have a huge(not nece'ly full screen) g-t window with lots of text in it and just moving your mouse inside it will raise your CPU usage. You can hold CTRL down and left click on a URL and it will open up a epiphany/galeon/mozilla window or CTRL-right click will popup a special URL menu. The code keeps matching the URL even when CTRL is not held. This patch makes sure that pattern match happens only when CTRL is pressed, because that's the only codepath using the matched string. Selecting text will raise CPU usage more. Huge amounts of scrolling text will also produce the similar spike in CPU. Added to gnome-terminal 2.6.1-r1. |