Summary: | app-admin/ulogd-2.0.4 with kernel 3.17 - In file included from libipulog.c:31:0: ../include/libipulog/libipulog.h:13:43: fatal error: linux/netfilter_ipv4/ipt_ULOG.h: No such file or directory | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Thomas Deutschmann (RETIRED) <whissi> |
Component: | Current packages | Assignee: | Coacher <itumaykin+gentoo> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint, thomas.bettler |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugzilla.netfilter.org/show_bug.cgi?id=986 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ulogd-2.0.4.patch
ulogd-2.0.4-r1.ebuild include-keep-a-copy-of-linux-netfilter_ipv4-ipt_ULOG.patch |
Description
Thomas Deutschmann (RETIRED)
2014-11-05 12:40:54 UTC
It is actual building with linux-3.17... but it requires <sys-kernel/linux-headers-3.17. But it will crash when you start it with an active kernel >=linux-3.17. Hello. Thank you for your report. I was expecting problems with ulogd as long-time deprecated ULOG target was removed since 3.17 kernel release. And this is really what this bug report is about. Currently, ulogd has no option to be built without ULOG target support, AFAIK. I'll see what can be done here. (In reply to Thomas D. from comment #1) > It is actual building with linux-3.17... but it requires > <sys-kernel/linux-headers-3.17. > > But it will crash when you start it with an active kernel >=linux-3.17. I've done some testing on my machine. It's true, ulogd won't build with >=linux-headers-3.17 for obvious reasons, but ulogd starts fine with active kernel 3.17.2. Moreover, if you have no stacks that use ULOG target, ulogd starts without hassle. If you do have a stack with ULOG target, ulogd will print error about this specific stack failing to start, but non-ULOG stacks are initialized fine. Can you confirm this? Later today I'll prepare patch for current ebuilds in tree to add proper dependency on linux-headers and a warning message as a workaround. But proper solution has to be done upstream. I'll submit bugreport to upstream bugzilla as well. Created attachment 388790 [details, diff]
ulogd-2.0.4.patch
Here is a patch that adds a dependency over <linux-headers-3.17 and prints a warning if there is no support for targets besides ULOG with >=kernel-3.17.0.
Also SRC_URI was expanded a bit.
@proxy-maint, please apply these changes to ebuilds in tree, both ulogd-2.0.3 and ulogd-2.0.4. No revbump needed here.
(In reply to Coacher from comment #3) > (In reply to Thomas D. from comment #1) > > It is actual building with linux-3.17... but it requires > > <sys-kernel/linux-headers-3.17. > > > > But it will crash when you start it with an active kernel >=linux-3.17. > > I've done some testing on my machine. > > It's true, ulogd won't build with >=linux-headers-3.17 for obvious reasons, > but ulogd starts fine with active kernel 3.17.2. Moreover, if you have no > stacks that use ULOG target, ulogd starts without hassle. If you do have a > stack with ULOG target, ulogd will print error about this specific stack > failing to start, but non-ULOG stacks are initialized fine. > > Can you confirm this? Yup, that was my problem, I ignored your elog > * You must have at least one logging stack enabled to make ulogd work. After I adjusted the CFG, ulogd was able to start on my running linux-3.17.2 system. Sorry for that. (In reply to Coacher from comment #4) > Created attachment 388790 [details, diff] [details, diff] > ulogd-2.0.4.patch > > Here is a patch that adds a dependency over <linux-headers-3.17 and prints a > warning if there is no support for targets besides ULOG with >=kernel-3.17.0. > > Also SRC_URI was expanded a bit. > > @proxy-maint, please apply these changes to ebuilds in tree, both > ulogd-2.0.3 and ulogd-2.0.4. No revbump needed here. Will this be fixed upstream? I fixed 2.0.4 only. No need to touch the stable one at the moment. Thanks for the report. + 08 Nov 2014; Markos Chandras <hwoarang@gentoo.org> ulogd-2.0.4.ebuild: + Add dependency to <linux-headers-3.17. Print warnings >for kernel-3.17. Patch + by Coacher <itumaykin@gmail.com>. Bug #528310 + (In reply to Markos Chandras from comment #6) > (In reply to Coacher from comment #4) > > Created attachment 388790 [details, diff] [details, diff] [details, diff] > > ulogd-2.0.4.patch > > > > Here is a patch that adds a dependency over <linux-headers-3.17 and prints a > > warning if there is no support for targets besides ULOG with >=kernel-3.17.0. > > > > Also SRC_URI was expanded a bit. > > > > @proxy-maint, please apply these changes to ebuilds in tree, both > > ulogd-2.0.3 and ulogd-2.0.4. No revbump needed here. > > Will this be fixed upstream? Yes. There is already a patch from devs they've asked me to test. I'll get to it when I have free time. Probably by Sunday evening I'll be able to test it and if it works we can include it in our ebuilds. (In reply to Markos Chandras from comment #7) > I fixed 2.0.4 only. No need to touch the stable one at the moment. Thanks > for the report. > > + 08 Nov 2014; Markos Chandras <hwoarang@gentoo.org> ulogd-2.0.4.ebuild: > + Add dependency to <linux-headers-3.17. Print warnings >for kernel-3.17. > Patch > + by Coacher <itumaykin@gmail.com>. Bug #528310 > + Thanks! Created attachment 389454 [details]
ulogd-2.0.4-r1.ebuild
@proxy-maint, I need your advise on this one.
There is a patch available upstream that 'fixes' this issue, i.e. ulogd can be compiled with linux-headers-3.17. I've tested it on my machine and it works fine. Should we push it via revbump or we can simply update existing ulogd-2.0.4 ebuild?
I've attached needed files to this bugreport: updated ebuild and upstream patch itself.
Created attachment 389456 [details, diff]
include-keep-a-copy-of-linux-netfilter_ipv4-ipt_ULOG.patch
Reopening for another ebuild update on this one. (In reply to Coacher from comment #10) > Created attachment 389454 [details] > ulogd-2.0.4-r1.ebuild > > @proxy-maint, I need your advise on this one. > > There is a patch available upstream that 'fixes' this issue, i.e. ulogd can > be compiled with linux-headers-3.17. I've tested it on my machine and it > works fine. Should we push it via revbump or we can simply update existing > ulogd-2.0.4 ebuild? > I don't think a revnbump is needed here. I haven't installed the package myself, but my best guess is that it won't change files which already installed? (correct me if I'm wrong) so users previously with <linux-headers-3.17 installed and have already successfully emerged ulogd don't have to install this package again (without any files changed?). users who previously installed >=linux-headers-3.17, and failed to install ulogd, now they find that they can install this ebuild successfully, no regressions. + 18 Nov 2014; Yixun Lan <dlan@gentoo.org> ulogd-2.0.4.ebuild, + +files/ulogd-2.0.4-linux-headers-3.17-ipt_ulog.patch: + fix compile err with >=linux-headers-3.17, bug 528310 pushed in tree without revision bump, since no files installed will change,thanks (In reply to Coacher from comment #11) > Created attachment 389456 [details, diff] [details, diff] > include-keep-a-copy-of-linux-netfilter_ipv4-ipt_ULOG.patch btw, I slightly rename the patch to keep it sync with Gentoo's convention, using ${P}-blah-blah.patch, or take a look at [1], thanks [1] http://dev.gentoo.org/~vapier/clean-patches (In reply to Yixun Lan from comment #14) > + 18 Nov 2014; Yixun Lan <dlan@gentoo.org> ulogd-2.0.4.ebuild, > + +files/ulogd-2.0.4-linux-headers-3.17-ipt_ulog.patch: > + fix compile err with >=linux-headers-3.17, bug 528310 > > pushed in tree without revision bump, since no files installed will > change,thanks Thanks. (In reply to Yixun Lan from comment #15) > (In reply to Coacher from comment #11) > > Created attachment 389456 [details, diff] [details, diff] [details, diff] > > include-keep-a-copy-of-linux-netfilter_ipv4-ipt_ULOG.patch > > btw, I slightly rename the patch to keep it sync with Gentoo's convention, > using ${P}-blah-blah.patch, or take a look at [1], thanks > > [1] http://dev.gentoo.org/~vapier/clean-patches Fine with me. Thanks for the link. |