Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 528256

Summary: app-arch/gcab-0.4 - library for working with MS cabinet files
Product: Gentoo Linux Reporter: M8R-u38wij
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED FIXED    
Severity: enhancement CC: gnome
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://wiki.gnome.org/msitools
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 528258    
Attachments: gcab-0.4.ebuild

Description M8R-u38wij 2014-11-04 19:38:49 UTC
Created attachment 388542 [details]
gcab-0.4.ebuild

Library for work with MS cabinet files. Dependency for msitools
Comment 1 Pacho Ramos gentoo-dev 2015-06-07 10:22:37 UTC
Looks like builder component of new appstream-glib will need this :/
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-06-09 02:38:35 UTC
(In reply to M8R-u38wij from comment #0)
> Created attachment 388542 [details]
> gcab-0.4.ebuild

Ebuild review:

* you forgot dependencies on glib and zlib. Remember to use "scanelf -n" to check what your compiled binaries link to.
* AFAICT, gobject-introspection-common and vala-common dependencies are needed here only if doing eautoreconf (for example, if building a git checkout, or if applying patches to configure.ac or Makefile.am)
* ECONF_SOURCE=${S} is needed only for out-of-source-tree builds, typically for multilib. Not needed here.
* don't enable static libraries unless it's a core system library or there is a realistic scenario why users want the static library
* you need GCONF_DEBUG and VALA_USE_DEPEND
* you need to call both gnome2_src_prepare and (if vala USE flag is enabled) vala_src_prepare
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-06-09 02:40:59 UTC
Added to portage with the above fixes.

+*gcab-0.6 (09 Jun 2015)
+
+  09 Jun 2015; Alexandre Rostovtsev <tetromino@gentoo.org> +gcab-0.6.ebuild,
+  +metadata.xml:
+  Library and tool for dealing with Microsoft CAB files, needed for some Gnome
+  components; bug #528256, thanks to M8R-u38wij for the ebuild.