Bug 527720 – app-emulation/spice-vdagent should only use RDEPEND for SELinux policy package dependency

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Sven Vermeulen (RETIRED) 2014-11-01 09:38:22 UTC]

Please remove the "selinux? ( sec-policy/selinux-* )" dependency in the DEPEND variable (not RDEPEND). Take this into account with your next package bump - if after 6 months there have been no need for other package upgrades, we will be bumping the package(s) ourselves with just this change.

For more information, see our tracker Bug #527698 [1]. The requested change will be posted as a separate comment/patch. Note that if the package also depends on libselinux, libselinux itself should still remain in DEPEND and RDEPEND.

[1] https://bugs.gentoo.org/show_bug.cgi?id=527698


Reproducible: Always

[Comment 1 Sven Vermeulen (RETIRED) 2014-11-01 09:38:52 UTC]

Index: spice-vdagent-0.10.1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-emulation/spice-vdagent/spice-vdagent-0.10.1.ebuild,v
retrieving revision 1.6
diff -u -B -r1.6 spice-vdagent-0.10.1.ebuild
--- spice-vdagent-0.10.1.ebuild 6 Aug 2014 06:44:37 -0000       1.6
+++ spice-vdagent-0.10.1.ebuild 1 Nov 2014 09:38:33 -0000
@@ -15,16 +15,17 @@
 KEYWORDS="~amd64 ~x86"
 IUSE="+consolekit selinux"
 
-RDEPEND="x11-libs/libXfixes
+CDEPEND="x11-libs/libXfixes
        x11-libs/libXrandr
        x11-libs/libX11
        x11-libs/libXinerama
        >=x11-libs/libpciaccess-0.10
        >=app-emulation/spice-protocol-0.10.1
-       consolekit? ( sys-auth/consolekit sys-apps/dbus )
-       selinux? ( sec-policy/selinux-vdagent )"
+       consolekit? ( sys-auth/consolekit sys-apps/dbus )"
 DEPEND="virtual/pkgconfig
-       ${RDEPEND}"
+       ${CDEPEND}"
+RDEPEND="${CDEPEND}
+       selinux? ( sec-policy/selinux-vdagent )"
 
 CONFIG_CHECK="~INPUT_UINPUT ~VIRTIO_CONSOLE"
 ERROR_INPUT_UINPUT="User level input support is required"
Index: spice-vdagent-0.12.0.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-emulation/spice-vdagent/spice-vdagent-0.12.0.ebuild,v
retrieving revision 1.3
diff -u -B -r1.3 spice-vdagent-0.12.0.ebuild
--- spice-vdagent-0.12.0.ebuild 6 Aug 2014 06:44:37 -0000       1.3
+++ spice-vdagent-0.12.0.ebuild 1 Nov 2014 09:38:33 -0000
@@ -15,16 +15,17 @@
 KEYWORDS="~amd64 ~x86"
 IUSE="+consolekit selinux"
 
-RDEPEND="x11-libs/libXfixes
+CDEPEND="x11-libs/libXfixes
        x11-libs/libXrandr
        x11-libs/libX11
        x11-libs/libXinerama
        >=x11-libs/libpciaccess-0.10
        >=app-emulation/spice-protocol-0.10.1
-       consolekit? ( sys-auth/consolekit sys-apps/dbus )
-       selinux? ( sec-policy/selinux-vdagent )"
+       consolekit? ( sys-auth/consolekit sys-apps/dbus )"
 DEPEND="virtual/pkgconfig
-       ${RDEPEND}"
+       ${CDEPEND}"
+RDEPEND="${CDEPEND}
+       selinux? ( sec-policy/selinux-vdagent )"
 
 CONFIG_CHECK="~INPUT_UINPUT ~VIRTIO_CONSOLE"
 ERROR_INPUT_UINPUT="User level input support is required"
Index: spice-vdagent-0.8.1-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-emulation/spice-vdagent/spice-vdagent-0.8.1-r1.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 spice-vdagent-0.8.1-r1.ebuild
--- spice-vdagent-0.8.1-r1.ebuild       6 Aug 2014 06:44:37 -0000       1.5
+++ spice-vdagent-0.8.1-r1.ebuild       1 Nov 2014 09:38:33 -0000
@@ -15,14 +15,15 @@
 KEYWORDS="~amd64"
 IUSE="+consolekit selinux"
 
-RDEPEND="x11-libs/libXfixes
+CDEPEND="x11-libs/libXfixes
        x11-libs/libXrandr
        x11-libs/libX11
        >=app-emulation/spice-protocol-0.8.1
-       consolekit? ( sys-auth/consolekit sys-apps/dbus )
-       selinux? ( sec-policy/selinux-vdagent )"
+       consolekit? ( sys-auth/consolekit sys-apps/dbus )"
 DEPEND="virtual/pkgconfig
-       ${RDEPEND}"
+       ${CDEPEND}"
+RDEPEND="${CDEPEND}
+       selinux? ( sec-policy/selinux-vdagent )"
 
 CONFIG_CHECK="~INPUT_UINPUT"
 ERROR_INPUT_UINPUT="User level driver support is required to run the spice-vdagent daemon"

[Comment 2 Sven Vermeulen (RETIRED) 2014-11-02 08:03:29 UTC]

After checking with a few colleague developers it seems that this change does not need a revision bump after all. As such, I will make the necessary changes to the packages myself.

My apologies for the noise.