Summary: | dev-qt/qtgui:5 - add USE=gtkstyle | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Gino McCarty <onigino> |
Component: | [OLD] Library | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aklhfex, chewi, dannydubyav2.0, oleid |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
dev-qt/qtgui-5.3.2.ebuild gtkstyle use flag patch
dev-qt/qtgui-5.3.2.ebuild gtkstyle use flag patch |
Description
Gino McCarty
2014-10-26 01:01:42 UTC
Created attachment 387390 [details, diff]
dev-qt/qtgui-5.3.2.ebuild gtkstyle use flag patch
This compiled and works fine for me..
not to sure about the QT5_GENTOO_CONFIG variable though
Maybe I missed something But I'm not seeing the linking reported here in the eclass.. I'm also building against 1.12.16 cairo stable so there is no qt4 use flag... " # disable gtkstyle because it adds qt4 include paths to the compiler # command line if x11-libs/cairo is built with USE=qt4 (bug 433826) -no-gtkstyle " This bug report is from 5.0_beta of qt so maybe its been fixed now in 5.3.2? I searched upstream but could find no bug relating to this, i really don't want to comb through their commits.. Created attachment 387402 [details, diff]
dev-qt/qtgui-5.3.2.ebuild gtkstyle use flag patch
(In reply to Harvey Mittens from comment #2) > Maybe I missed something But I'm not seeing the linking reported here in the > eclass.. > > I'm also building against 1.12.16 cairo stable so there is no qt4 use flag... > USE=qt4 is masked in base/package.use.mask > This bug report is from 5.0_beta of qt so maybe its been fixed now in 5.3.2? > I searched upstream but could find no bug relating to this, i really don't > want to comb through their commits.. It's not a qt bug so I doubt you'll find fixes there... (In reply to Davide Pesavento from comment #4) > (In reply to Harvey Mittens from comment #2) > > Maybe I missed something But I'm not seeing the linking reported here in the > > eclass.. > > > > I'm also building against 1.12.16 cairo stable so there is no qt4 use flag... > > > > USE=qt4 is masked in base/package.use.mask > > > This bug report is from 5.0_beta of qt so maybe its been fixed now in 5.3.2? > > I searched upstream but could find no bug relating to this, i really don't > > want to comb through their commits.. > > It's not a qt bug so I doubt you'll find fixes there... I think your right, i went ahead and tested with cairo 1.4.0 with qt4 enabled and qtgui-5.3.2 and it still doesn't compile.. however I do see some message board comments about cairo being able to compile against qt5.. however I'm not sure how to make it to this.. http://lists.cairographics.org/archives/cairo/2012-February/022715.html I think this should be added. The qt4 flag on cairo is masked and it's caused nothing but breakage anyway; no package actually requires it. Is there any packages that requires +qt4 in cairo? equery depends cairo | grep qt4 reports nothing. (In reply to Olaf Leidinger from comment #7) > Is there any packages that requires +qt4 in cairo? No, that's what I already said. Seems to require qtwidgets to be built with -gtksytle as well. Thanks, in overlay. https://gitweb.gentoo.org/proj/qt.git/commit/?id=78d066c32d911b68b85794cf2bdc93aca37cde58 https://gitweb.gentoo.org/proj/qt.git/commit/?id=eb9152725baf126b185df14a43035149bf9504ac https://gitweb.gentoo.org/proj/qt.git/commit/?id=c4685af536ac38f671c89f86c8e6f7f17fee7940 I should add that I think we should proceed due to demand and the fact that cairo[qt4] is masked and not required by anything. We can revisit filtering out the bad includes later if it becomes necessary. (In reply to Michael Palimaka (kensington) from comment #11) > I should add that I think we should proceed due to demand and the fact that > cairo[qt4] is masked and not required by anything. We can revisit filtering > out the bad includes later if it becomes necessary. Sure, feel free to apply to 5.4.1 in tree as well. The qt4 USE flag doesn't exist anymore in >=x11-libs/cairo-1.14.2, so the blocker is fine IMO. Thanks, fixed in CVS. + 19 Apr 2015; Michael Palimaka <kensington@gentoo.org> qtgui-5.4.1-r1.ebuild: + Add gtkstyle USE flag by Harvey Mittens <teknocratdefunct@riseup.net> and + Davide Pesavento <pesa@gentoo.org> wrt bug #526866. + 19 Apr 2015; Michael Palimaka <kensington@gentoo.org> metadata.xml, + qtwidgets-5.4.1.ebuild: + Add gtkstyle USE flag wrt bug #526866. |