Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 5259

Summary: conectiva-crystal-3.1_beta37-r1.ebuild
Product: Gentoo Linux Reporter: Daniel Mettler <mettlerd>
Component: New packagesAssignee: Dan Armak (RETIRED) <danarmak>
Severity: minor CC: mettlerd
Priority: High    
Version: 1.3   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Attachments: new ebuild
conectiva-crystal-3.1_beta37-r2.ebuild (replaces the conectiva-crystal-3.1_beta37-r1.ebuild attachment)

Description Daniel Mettler 2002-07-19 14:52:20 UTC
dan, as you wrote that KDE3DIR etc. variables will be deprecated soon i       
commented them out for my gentoo 1.3b test drive.   
now, without these variables set, the conectiva-crystal-3.1_beta37.ebuild will    
install into the root tree (/share/icons/Crystal) instead of the kde base    
to solve this, i've made an ebuild which should work both for old _and_ new   
gentoo versions. that's how it works: if available, it uses $KDE2DIR and   
$KDE3DIR variables. if not available, it parses and uses $KDEDIRS. if it does   
not find any of these variables or if it does not find any of the specified 
directories it aborts (see the source for details).   
disclaimer: i do not know about the variables you intend to use instead of   
$KDExDIR in the future (perhaps parse KDEDIRS too?). thus there might be an 
even more elegant solution than this one ;)   
plse see the attachment for the ebuild.  
ps. imo it should work for ppc too (though i only tested it for i86)
Comment 1 Daniel Mettler 2002-07-19 14:54:05 UTC
Created attachment 2399 [details]
new ebuild
Comment 2 Daniel Mettler 2002-07-21 09:47:46 UTC
Created attachment 2433 [details]
conectiva-crystal-3.1_beta37-r2.ebuild (replaces the conectiva-crystal-3.1_beta37-r1.ebuild attachment)

includes changes to make the ebuild pass lintool (there is still a warning
about the malformed cvs header of course):

--- conectiva-crystal-3.1_beta37-r1.ebuild	Sun Jul 21 16:40:24 2002
+++ conectiva-crystal-3.1_beta37-r2.ebuild	Sun Jul 21 16:32:48 2002
@@ -10,6 +10,9 @@

 src_compile() {

	return 1;
@@ -18,7 +21,7 @@


-	successful="false";						       
					# Success is defined as at least one
installation of the icon theme.
+	successful="false";						       
				# Success is defined as at least one
installation of the icon theme.

	cd ${S}
Comment 3 Dan Armak (RETIRED) gentoo-dev 2002-07-29 10:18:15 UTC
I'm committed an -r1 that uses eclasses to determine where to install. 
kde-functions.eclass passes $KDEDIR and $PREFIX to an ebuild, and the ebuild 
uses kdelibs from $KDEDIR and installs in $PREFIX. 
Also btw kde 3.1 tree includes this icon theme. 
Comment 4 Daniel Mettler 2002-07-29 11:26:30 UTC
o'right. i didn't know it will be included with 3.1 and using your eclasses is 
certainly a good idea.