|Summary:||xfce-extra/xfce4-weather-plugin - no longer receiving data|
|Product:||Gentoo Linux||Reporter:||Christian Tietz <christian.tietz>|
|Component:||Current packages||Assignee:||XFCE Team <xfce>|
|Severity:||normal||CC:||david.w.noon, drunkenbatman, gokturk, rom|
|Package list:||Runtime testing required:||---|
Patch to weather.c for API 1.2
Patch to weather-parsers.c
Patch to weather-translate.c
Patch to weather-translate.h
Description Christian Tietz 2014-10-09 15:53:40 UTC
There is an upstream bug: https://bugzilla.xfce.org/show_bug.cgi?id=10916 Reproducible: Always
Comment 1 Gerold Schellstede 2014-10-09 19:46:36 UTC
My weather plugin suffers from the same bug. It says "no data".
Comment 2 Christian Tietz 2014-10-09 20:01:47 UTC
I could fix it for me by recompliling the plugin after applying the patches that are mentioned in the upstream bug and have already been pushed to git.
Comment 3 Greg Kubaryk 2014-10-11 23:50:47 UTC
I can confirm that applying patches 1ff71669644a0b824a8a5ba9b40771ee4fb8a76b and 7df303bc5fa649299e18efeb5d4b801614030488 from upstream git resolves this issue locally. For users not interested in waiting, this ebuild is epatch_user enabled.
Comment 4 David W Noon 2014-10-17 22:45:48 UTC
Created attachment 386844 [details, diff] Patch to weather.c for API 1.2
Comment 5 David W Noon 2014-10-17 22:46:36 UTC
Created attachment 386846 [details, diff] Patch to weather-parsers.c
Comment 6 David W Noon 2014-10-17 22:47:18 UTC
Created attachment 386848 [details, diff] Patch to weather-translate.c
Comment 7 David W Noon 2014-10-17 22:47:58 UTC
Created attachment 386850 [details, diff] Patch to weather-translate.h
Comment 8 victor romanchuk 2014-10-18 06:05:17 UTC
applied as user patch; now plugin works for me thanks
Comment 9 Yarda 2014-10-29 15:56:57 UTC
Created attachment 387744 [details, diff] Backported fix Sorry, your patches doesn't apply for me to xfce4-weather-plugin-0.8.3-r1. Attached is backport that we have used in Fedora, it works for me.
Comment 10 Samuli Suominen (RETIRED) 2014-10-29 17:06:49 UTC
patches committed, and directly to stable, special case, because this relies upon external services as in, +*xfce4-weather-plugin-0.8.3-r2 (29 Oct 2014) + + 29 Oct 2014; Samuli Suominen <firstname.lastname@example.org> +files/xfce4-weather-plugi + n-0.8.3-Fix-color-parsing-when-reading-config-file.patch, +files/xfce4-weather + -plugin-0.8.3-Make-plugin-ready-for-met.no-locationforecast-1.2-AP.patch, +fil + es/xfce4-weather-plugin-0.8.3-Switch-to-met.no-locationforecastLTS-1.2-API-bug + -109.patch, +xfce4-weather-plugin-0.8.3-r2.ebuild: + Import upstream patches for fetching weather information wrt #524850 by + Christian Tietz, David W. Noon, "Yarda" and others. Commit to stable because + current stable is useless if it can't fetch the data.