Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 524648

Summary: app-editors/vim - vim-patches-7.4.273.patch overrides vimrc settings for tabstop formatting in python sources
Product: Gentoo Linux Reporter: Alexander Soloviëv <no.friday>
Component: Current packagesAssignee: Vim Maintainers <vim>
Status: RESOLVED UPSTREAM    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Alexander Soloviëv 2014-10-06 21:06:11 UTC
Within vim-patches-7.4.273.patch have arrived stupid patch for ftplugin/python.vim that unconditionally enforces the following tab settings for all python sources:

+" As suggested by PEP8.
+setlocal expandtab shiftwidth=4 softtabstop=4 tabstop=8

Any global enforcments inspired by some code formatting recommendations must not be used unconditionally in global configs.

Reproducible: Always
Comment 1 Tim Harder gentoo-dev 2014-10-07 05:33:19 UTC
(In reply to Alexander Soloviëv from comment #0)
> Within vim-patches-7.4.273.patch have arrived stupid patch for
> ftplugin/python.vim that unconditionally enforces the following tab settings
> for all python sources:
> 
> +" As suggested by PEP8.
> +setlocal expandtab shiftwidth=4 softtabstop=4 tabstop=8
> 
> Any global enforcments inspired by some code formatting recommendations must
> not be used unconditionally in global configs.

Take this up with upstream, this isn't a change made by Gentoo. Also, I'd rather avoid adding to the patch set we already apply against vim's runtime files as much as possible.

In the meantime, you can always add the settings into ~/.vim/after/ftplugin/python.vim that you want to override the upstream ones.