Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 523522

Summary: sys-cluster/ceph uses readme.gentoo.eclass install phase even if ebuild takes care of installation itself
Product: Gentoo Linux Reporter: Martin Kletzander <mkletzan>
Component: EclassesAssignee: Yixun Lan <dlan>
Status: RESOLVED FIXED    
Severity: normal CC: cluster
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Martin Kletzander 2014-09-23 12:21:34 UTC
When installing e.g. sys-clister/ceph, static libtool archives get installed even without the static-libs use flag.  That is because the ebuild does the following things in src_install():

  default
  fix_libtool_files --all
  readme.gentoo_src_install

I believe this could be fixed globally by removing the line "default" from the readme.gentoo_src_install()

Reproducible: Always

Steps to Reproduce:
1. USE=-static-libs emerge ceph
2. ls /usr/lib/lib{rados,rbd,cephfs}.la
Actual Results:  
$ ls /usr/lib/lib{rados,rbd,cephfs}.la
/usr/lib/libcephfs.la  /usr/lib/librados.la  /usr/lib/librbd.la

Expected Results:  
$ ls /usr/lib/lib{radosa,rbda,cephfsa}.la
ls: cannot access /usr/lib/librados.la: No such file or directory
ls: cannot access /usr/lib/librbd.la: No such file or directory
ls: cannot access /usr/lib/libcephfs.la: No such file or directory

At the time of posting this, *all* packages that do readme.gentoo_src_install call some kind of src_install before that apart from the following 2, that do "doins -r *":

dev-util/pycharm-professional
dev-util/pycharm-community
Comment 1 Pacho Ramos gentoo-dev 2014-09-23 13:22:17 UTC
Open bugs for packages using the install phase instead of readme.gentoo_create_doc then (the default phases will be dropped in eapi6 for this eclass... but ebuilds should simply call readme.gentoo_create_doc if they are installing the rest manually or using other eclass providing src_install phase)
Comment 2 Pacho Ramos gentoo-dev 2014-09-23 13:23:33 UTC
(In reply to Pacho Ramos from comment #1)
> Open bugs for packages using the install phase instead of
> readme.gentoo_create_doc then

=> I mean packages that are handling install phase themselves of course, if they are not doing anything special at that time they can use the phase of course (as they can do for any other eclass providing phase functions)

> (the default phases will be dropped in eapi6
> for this eclass... but ebuilds should simply call readme.gentoo_create_doc
> if they are installing the rest manually or using other eclass providing
> src_install phase)
Comment 3 Pacho Ramos gentoo-dev 2014-09-24 09:27:50 UTC
ceph maintainer, I see two options:
- replace "default" by readme.gentoo_src_install at the top of install function
- replace readme.gentoo_src_install with readme.gentoo_create_doc

readme.gentoo_src_install phase runs "default && readme.gentoo_create_doc"
Comment 4 Martin Kletzander 2014-09-24 12:20:49 UTC
Thank you for handling this bug.  Are there some options other than filing bugs for each package separately?  I'd gladly send some global patch or something if there's such possibility.
Comment 5 Yixun Lan archtester gentoo-dev 2014-09-24 13:45:20 UTC
+  24 Sep 2014; Yixun Lan <dlan@gentoo.org> ceph-0.67.9.ebuild,
+  ceph-0.67.10.ebuild, ceph-0.80.5.ebuild, ceph-9999.ebuild:
+  fix libtool archives issue, readme.gentoo related, bug 523522

fixed without revision bump, and I take the second approach, thanks