Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 522248

Summary: dev-perl/DBD-mysql-4.20.0 - ?
Product: Gentoo Linux Reporter: Daniel Kovacs <kovacsdanielhun>
Component: [OLD] DevelopmentAssignee: Gentoo Perl team <perl>
Status: RESOLVED UPSTREAM    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Daniel Kovacs 2014-09-06 09:12:35 UTC
In the original code, there is a missing if-endif part, and under several conditions the compile fails.

Patch:

diff -rupN DBD-mysql-4.020/dbdimp.c DBD-mysql-4.020-new/dbdimp.c
--- DBD-mysql-4.020/dbdimp.c    2011-08-20 20:35:59.000000000 +0200
+++ DBD-mysql-4.020-new/dbdimp.c        2014-09-05 17:49:24.621195143 +0200
@@ -3473,7 +3473,9 @@ int dbd_st_execute(SV* sth, imp_sth_t* i
         return 0;
     }
 #endif
+#if MYSQL_VERSION_ID >= SERVER_PREPARE_VERSION
   }
+#endif

   if (imp_sth->row_num+1 != (my_ulonglong)-1)
   {
Comment 1 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-09-06 14:47:41 UTC
why should we implement this one into gentoo instead upstream? We should not.