Bug 52206 – Catch-all ACCEPT_KEYWORDS / package.keywords

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Ed Catmur 2004-05-27 12:20:27 UTC]

See, for instance, bug 51705. If we are to be able to test packages not ready for unstable yet then we need to be able to unmask them without having to continually check what KEYWORDS they currently have. When an arch is missing from KEYWORDS it simply means that that arch is untested; it should not be made overly difficult for testing to be carried out by non-developers.

The attached patch allows a package.keywords of "*" to match all KEYWORDS except "-arch".

I understand that the last thing we want is users installing untested packages left right and centre and filing pointless bugs; as such I am happy to make any changes necessary to prevent the use of this proposed feature by the great unwashed.

[Comment 1 Ed Catmur 2004-05-27 12:22:22 UTC]

Created attachment 32155 [details, diff]
Proposed patch

[Comment 2 Ciaran McCreesh 2004-05-27 12:46:27 UTC]

Hrm, for arch maintainers, this could be fairly useful... For sparc testing we usually tell people to stick ~x86 x86 in package.keywords for testing unkeyworded apps, but this is kinda messy. One other possibility -- how about * (matches stable on any arch) and ~* (~arch)?

Cc:ing sparc because getting lots of bugzilla emails makes us feel loved, erm, I mean because this could influence some of our documentation.

[Comment 3 Ed Catmur 2004-05-27 16:47:19 UTC]

Created attachment 32175 [details, diff]
New patch

Yes, I prefer that suggestion.
This implementation is a little verbose but is efficient and readable.

[Comment 4 Ed Catmur 2004-05-27 17:05:10 UTC]

Created attachment 32177 [details, diff]
Replacement patch

Oops, that was broken. Use this.

[Comment 5 SpanKY 2004-05-27 21:04:10 UTC]

ive been doing the same exact thing when porting to arm ... sticking '~x86 x86' into package.keywords and just assuming that the package works for x86 :)

something like this would be cool

[Comment 6 Nicholas Jones (RETIRED) 2004-05-28 16:00:41 UTC]

I think it's slightly off on the ~* logic.

You have it only matching ~arch and not stable in that case.
Including and modifying a little.

[Comment 7 Nicholas Jones (RETIRED) 2004-05-28 16:02:36 UTC]

        if "~*" in pgroups:
          for gp in mygroups:
            if gp[0] != "-":
              match=1
              break

[Comment 8 Ciaran McCreesh 2004-05-28 16:14:38 UTC]

If I add ~x86 to package.keywords, it only matches ~x86, not x86, right?

[Comment 9 Ed Catmur 2004-05-29 05:59:00 UTC]

Yes, that was my understanding and the reason I wrote the patch the way I did.

[Comment 10 Brian Harring (RETIRED) 2004-08-16 11:38:48 UTC]

As far as I can tell, this is in pre18.
Reopen if I'm wrong :)