Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 521170

Summary: media-sound/pulseaudio: bash-completion files are not compatible with autoloading
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: alexander, sound
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=84921
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 521146    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-08-26 18:43:43 UTC
$ ./get-completions /usr/share/bash-completion | ./completion-qa-check.py | grep pulsea
pulseaudio-bash-completion.sh: does not declare completion for pulseaudio-bash-completion.sh
parecord: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
pulseaudio: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
padsp: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
paplay: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
pasuspender: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
pactl: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
pacat: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)
pacmd: missing completion symlink for command (declared in /usr/share/bash-completion/pulseaudio-bash-completion.sh)

Long story short, the filenames need to match commands for autoloading to work. You want a layout like:

  pulseaudio
  pacat -> pulseaudio
  pacmd -> pulseaudio
  ...

in $completionsdir.
Comment 1 Alex Turbov 2014-11-11 21:50:44 UTC
why not to add automatic symlinks createion to `bash-completion-r1.eclass`??
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-11-11 22:06:51 UTC
1. It's just a utility eclass. In this particular package, it isn't even used after the configure stage. The Makefile installs completions.

2. The check is complex and imperfect and never will be. You have to evaluate the results, not apply them blindly.

3. Hacking things around with an eclass means never having bugs fixed upstream.
Comment 3 Pacho Ramos gentoo-dev 2015-09-24 17:52:08 UTC
it looks to be ok with 7.0