Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 519682

Summary: readme.gentoo-r1.eclass should expand common PMS variables
Product: Gentoo Linux Reporter: Justin Lecher (RETIRED) <jlec>
Component: EclassesAssignee: Pacho Ramos <pacho>
Status: CONFIRMED ---    
Severity: enhancement Keywords: NeedPatch
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://www.gossamer-threads.com/lists/gentoo/dev/291632
Whiteboard:
Package list:
Runtime testing required: ---

Description Justin Lecher (RETIRED) gentoo-dev 2014-08-12 06:24:46 UTC
If you like to point to documentation it would be cool to expand things like $PF. Is this possible?
Comment 1 Pacho Ramos gentoo-dev 2014-08-15 09:46:06 UTC
Not sure what do you mean sorry. It's now properly showing the directory when README.gentoo* ends up being installed, no? (at least in my case looks to work)

Thanks for the explanation :)
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2014-08-15 12:07:09 UTC
I mean if you like to put the following in the README.gentoo

"""
You can find an example config in /usr/share/doc/${PF}/foo.rc
"""

then there will be "${PF}" in the README instead of the variable content. Can we filter this? e.g. @PF@ -> ${PF}
Comment 3 Pacho Ramos gentoo-dev 2014-08-16 09:10:24 UTC
Then, I guess that instead of simply copying the file with "cp" as done currently we need something like:
eval echo $(cat "${FILESDIR}/README.gentoo-${SLOT%/*}") > "${T}"/README.gentoo || die
Comment 4 Pacho Ramos gentoo-dev 2014-09-01 12:18:27 UTC
As discussed at:
http://www.gossamer-threads.com/lists/gentoo/dev/291632

Will be better to handle only a set of known variables. I am thinking in handling: PF, PN, P, PV, HOMEPAGE

Do you think any other variable could be useful to be handled?

Thanks
Comment 5 Pacho Ramos gentoo-dev 2014-09-12 13:27:12 UTC
I have been playing with the x= substitutions suggested by mgorny but failed (things get shown disordered), will try with sed later :S