Bug 519552 – sys-process/acct-6.5.5-r3 - pacct_rd.c:(.text.double_2_comp_t+0x2c): undefined reference to `frexp'

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description René Rhéaume 2014-08-10 07:55:41 UTC]

Three programs in acct (lastcomm and 2 others) require linking to libm. It seems the requirement is not checked for uclibc. It is however overcome by appending LIBS="-lm" to (e)make command.

Reproducible: Always

Steps to Reproduce:
1. Install Lilblue
2. emerge acct
Actual Results:  
emake failed (compile phase)

Expected Results:  
acct installed on system

[Comment 1 René Rhéaume 2014-08-10 07:56:59 UTC]

Created attachment 382618 [details, diff]
acct ebuild patch adding src_compile

[Comment 2 René Rhéaume 2014-08-10 07:59:36 UTC]

Created attachment 382620 [details, diff]
patch to fix QA notice in files/acct.initd

I had this QA notice right after I was able emerge acct:

 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/acct line 13 (export foo=bar should be foo=bar; export foo):
 *      export ACCT_LOG=${ACCT_LOG:-/var/account/pacct}

This patch fixes this

[Comment 3 Jeroen Roovers (RETIRED) 2014-08-10 08:05:09 UTC]

1) Please post your `emerge --info' output in a comment.
2) Please attach the entire build log to this bug report.

[Comment 4 René Rhéaume 2014-08-12 01:39:11 UTC]

Created attachment 382696 [details]
build.log

[Comment 5 René Rhéaume 2014-08-12 01:39:40 UTC]

Created attachment 382698 [details]
emerge --info output

[Comment 6 SpanKY 2014-08-13 03:40:17 UTC]

Comment on attachment 382620 [details, diff]
patch to fix QA notice in files/acct.initd

the QA check is wrong

http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#export

[Comment 7 SpanKY 2014-08-13 03:59:52 UTC]

should be all set now in the tree; thanks for the report!

Commit message: Link with -lm when needed
http://sources.gentoo.org/sys-process/acct/acct-6.6.1.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/sys-process/acct/files/acct-6.6.1-math.patch?rev=1.1

[Comment 8 René Rhéaume 2014-08-13 23:49:11 UTC]

A few things, vapier:

1. I see two sa_LDADD added inside http://sources.gentoo.org/sys-process/acct/files/acct-6.6.1-math.patch , one for the sa target and the other one for the lastcomm target. Is that a mistake?

2. Will the (corrected) patch be applied to version 6.5.5-r3 as well? My general ACCEPT_KEYWORDS is amd64, not ~amd64 (although I could simply add acct to /etc/protage/package.accept_keywords).

3. Time for emerge --sync && emerge -u checkbashisms to get rid of false positives :)

[Comment 9 SpanKY 2014-08-14 12:50:52 UTC]

(In reply to René Rhéaume from comment #8)

this is only fixing latest unstable.  generally we fix unstable and let the fixes percolate down into stable.

[Comment 10 SpanKY 2014-08-14 12:53:00 UTC]

Commit message: Fix copy & paste fail
http://sources.gentoo.org/sys-process/acct/files/acct-6.6.1-math.patch?r1=1.1&r2=1.2