| Summary: | dev-java/eclipse-ecj eclipse-ecj-4.4.ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | William L. Thomson Jr. <wlt-ml> |
| Component: | [OLD] Java | Assignee: | Java team <java> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 501692, 506644 | ||
| Attachments: |
eclipse-ecj-4.4.ebuild
eclipse-ecj-4.4.ebuild eclipse-ecj-4.4.ebuild |
||
Created attachment 381372 [details]
eclipse-ecj-4.4.ebuild
Created attachment 381374 [details]
eclipse-ecj-4.4.ebuild
Some points: The build file doesn't specify the encoding, so this will fail already with plain ascii locale. Set the encoding (JAVA_ANT_ENCODING), my guess utf-8 or latin-1. java_prepare: rm -f never fails so the || die is pointles, don't use -f? src_install: there aren't any 1.4 classes anymore the way you build it, so why is the workaround still needed? (In reply to Ralph Sennhauser from comment #3) > Some points: > > The build file doesn't specify the encoding, so this will fail already with > plain ascii locale. Set the encoding (JAVA_ANT_ENCODING), my guess utf-8 or > latin-1. There are VERY few packages that set that. Most are either ISO-8859-1 or UTF-8. The old boot strap code used ISO-8859-1. I would just assume go with that. > java_prepare: > rm -f never fails so the || die is pointles, don't use -f? > > src_install: > there aren't any 1.4 classes anymore the way you build it, so why is the > workaround still needed? Both legacy code in all past ebuild versions, in prepare and install. Just make the changes and commit. Not sure the point in commenting. This is NOT all me, and many devs have overlooked this stuff in past revisions including yourself.... I mean more review and commit. Not review for feedback.... Bumped to 4.4.1 (slot 4.4) |
Created attachment 381306 [details] eclipse-ecj-4.4.ebuild Upated ebuild for eclipse-ecj-4.4, pending review. Ran into issues with circular dependencies with ant-eclipse-ecj-4.4. Also had issues with eselect-ecj which is presently blocked by eselect-java. I commented out both CDEPEND and PDEPEND for now to proceed with rest of ebuild. I removed/ditched the old src_compile with bootstrap. I think it was all legacy stuff from the 1.4 days no longer necessary. Should be good to go for the most part, once issues with circular dependencies and eselect are worked out.