| Summary: | ant-eclipse-ecj-4.4.ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | William L. Thomson Jr. <wlt-ml> |
| Component: | [OLD] Java | Assignee: | Java team <java> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
ant-eclipse-ecj-4.4.ebuild
files/ecj-4.4 |
||
Created attachment 381302 [details]
files/ecj-4.4
java environment file
As requested a review
src_unpack:
mkdir || die
src_compile:
cd || die
use find -exec for both
src_install:
You can't go and sed a file on the live system that may not even exist yet. Probably ${ED} went missing there. Actually, instead of sed you can use eprefixify from prefix.eclass.
(In reply to Ralph Sennhauser from comment #2) > As requested a review > > src_unpack: > mkdir || die > > src_compile: > cd || die > use find -exec for both > > src_install: > You can't go and sed a file on the live system that may not even exist yet. > Probably ${ED} went missing there. Actually, instead of sed you can use > eprefixify from prefix.eclass. All of that is in every previous version. Granted, I should catch and improve. No others devs including ones doing stabilising are picking that up. The sed code has been there as the other stuff. I believe the sed was broken. I fixed it and it caused another issue. No clue who added prefix support but they did not do it properly. I was not trying to fix that. Thanks for the review, but I mean more review and commit to tree.... Bumped to 4.4.1 (slot 4.4) |
Created attachment 381300 [details] ant-eclipse-ecj-4.4.ebuild Upated ebuild for ant-eclipse-ecj-4.4, pending review. Ran into issue with fixing sed for prefix, fixing path of installed ecj java-config environment file. Needs a better solution that does not cause access denied with sed's temp file. Commented that out for now, as it only effects prefix installs.