Summary: | dev-python/pygobject-3.12.2 fails tests | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Patrick Lauer <patrick> |
Component: | [OLD] Development | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kingjon3377, python |
Priority: | Normal | Keywords: | TESTFAILURE |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 553380 | ||
Bug Blocks: | |||
Attachments: | pygobject-3.16.2_build.log |
Description
Patrick Lauer
![]() ditto -3.13.3. Tests look to finally pass with 3.16.2 for me ~/cvsPortage/gentoo-x86/dev-python/pygobject $ PYTHON_TARGETS=python2_7 ebuild pygobject-3.16.2.ebuild clean test
Ran 1133 tests in 9.553s
OK (skipped=4, expected failures=12)
Ran 16 tests in 0.039s
OK
>>> Completed testing dev-python/pygobject-3.16.2
---------------------------------------------------------------
done
CHECK Pyflakes examples gi tests pygtkcompat
gi/_option.py:40: undefined name 'basestring'
gi/_propertyhelper.py:47: undefined name 'basestring'
gi/_propertyhelper.py:48: undefined name 'long'
gi/overrides/GObject.py:267: undefined name 'unicode'
gi/overrides/Gtk.py:35: undefined name 'basestring'
tests/test_properties.py:38: undefined name 'unicode'
tests/test_properties.py:873: undefined name 'long'
tests/test_everything.py:31: undefined name 'unicode'
tests/compathelper.py:66: undefined name 'long'
tests/compathelper.py:67: undefined name 'basestring'
tests/compathelper.py:69: undefined name 'unicode'
tests/test_gi.py:29: undefined name 'unicode'
Makefile:1175: recipe for target 'check-local' failed
make[2]: *** [check-local] Error 1
make[2]: Leaving directory '/mnt/gen2/TmpDir/portage/dev-python/pygobject-3.16.2/work/pygobject-3.16.2-python3_4'
Makefile:944: recipe for target 'check-am' failed
make[1]: *** [check-am] Error 2
make[1]: Leaving directory '/mnt/gen2/TmpDir/portage/dev-python/pygobject-3.16.2/work/pygobject-3.16.2-python3_4'
Makefile:661: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
(In reply to Ian Delaney from comment #3) > done > CHECK Pyflakes examples gi tests pygtkcompat > gi/_option.py:40: undefined name 'basestring' I don't understand how that error can happen. Please attach complete build log and emerge --info. Probably something like running python3 checker on python2 code or more likely, pyflakes not realizing this is backward compatibility code ? Created attachment 405708 [details]
pygobject-3.16.2_build.log
(In reply to Gilles Dartiguelongue from comment #5) > Probably something like running python3 checker on python2 code or more > likely, pyflakes not realizing this is backward compatibility code ? Right, and Ian confirmed on irc that he has pyflakes installed. Automagic build dependency that makes tests fail :) Fixed. We now pull in pyflakes for FEATURES=test, but run that test only in python2.7 mode, and disable it using sed in python3.x mode. (Except on sparc, where pyflakes unfortunately remains automagic due to lack of keyword - bug #553380) + 27 Jun 2015; Alexandre Rostovtsev <tetromino@gentoo.org> + pygobject-3.16.2.ebuild: + Fix test failure when pyflakes is installed (bug #516744, thanks to Ian + Delaney and Gilles Dartiguelongue). |