Summary: | [qt overlay] dev-qt/qtgui-5.3.0 not defining QT_OPENGL | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | JY <jy454> |
Component: | [OLD] Library | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | josef64 |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=510556 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | qconfig.h with fix |
Description
JY
2014-06-25 09:21:05 UTC
Fix available here : https://github.com/gentoo/qt/pull/57 The fix looks good, but I'm not sure if I understand what's really going on. We don't add QT_OPENGL because the configure script doesn't... # enable opengl if [ "$CFG_OPENGL" = "no" ]; then QCONFIG_FLAGS="$QCONFIG_FLAGS QT_NO_OPENGL" else QT_CONFIG="$QT_CONFIG opengl" fi Can you attach your entire qconfig.h please? Created attachment 379704 [details]
qconfig.h with fix
Ok I see what's going on... QtCore/qconfig.h is generated when qtcore is built, i.e. when the opengl deps may or may not be installed. If they're not, CFG_OPENGL is set to "no", QT_NO_OPENGL ends up in QCONFIG_FLAGS, and the preprocessor stuff is generated. Later, when qtgui is built, it's too late to change qconfig.h. The patch is therefore correct, however this is just one symptom of a more general problem that has to be fixed for good at the eclass level (see also bug 510556). |