Bug 514

Summary:	dev-java/ant installs even when there is an error
Product:	Gentoo Linux	Reporter:	Sandy McArthur <Sandy>
Component:	[OLD] Development	Assignee:	Karl Trygve Kalleberg (RETIRED) <karltk>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	1.0 RC6 r14
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	481

Description Sandy McArthur 2002-02-03 15:44:11 UTC

The problem is that the build.sh called by the ant ebuild doesn't  exit with an error 
code when there is a probem. The problem I had was that JDK_HOME wasn't in 
my enviroment  so JAVA_HOME got set to an empty string. If the ebuild die'ed 
on an empty JDK_HOME that would at least alert the user to a problem.

Comment 1 Daniel Robbins (RETIRED) gentoo-dev

2002-02-03 23:13:42 UTC

need some "|| die"s?

Comment 2 Sandy McArthur 2002-02-04 00:00:34 UTC

I'd say adding:

[ -n "$JDK_HOME" ] || die "Java JDK not properly installed. Please (re)install."

to the top of the src_compile()  function would be enough.

Comment 3 Geert Bevin 2002-02-05 01:29:52 UTC

Since it depends on virtual/jdk-1.3, the environment should be setup correctly.
However, maybe when an older jdk package is installed that didn't use the new
java scheme yet, this dep is resolved but the required env var is not present.
Is this possible?

Comment 4 Sandy McArthur 2002-02-05 09:00:46 UTC

Yup, The enviroment was set up correctly when I re-emerged the jdk I was using.

Comment 5 Karl Trygve Kalleberg (RETIRED) gentoo-dev

2002-02-05 12:19:06 UTC

I guess I should use -rX on virtual deps, too, to avoid this problem. If this
bug gets reopened later, I will bother :)