Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 513446

Summary: www-client/uzbl - fixes
Product: Gentoo Linux Reporter: tharvik
Component: Current packagesAssignee: Sven Vermeulen (RETIRED) <swift>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 453208, 456310, 486012, 490348, 506006    
Attachments: uzbl-9999.ebuild

Description tharvik 2014-06-16 08:36:31 UTC
This new ebuild should fix 453208, 456310, 486012, 490348, 506006.
I'm still unable to fix 481524, as I can not reproduce, maybe this ebuild will fix it.

Reproducible: Always
Comment 1 tharvik 2014-06-16 08:37:35 UTC
Created attachment 378992 [details]
uzbl-9999.ebuild

This ebuild is the same for both version (2012.05.14 and 9999).
Comment 2 Yixun Lan archtester gentoo-dev 2014-06-23 03:03:38 UTC
for version 2012.05.14, does it also fix all the bugs (453208, 456310, 486012, 490348, 506006)? if not, probably you can make a snapshot of upstream code?

also, I've run through your changes (check the diff vs current version in portage tree), you simply change " -> ', this seems are cosmetic changes, and cause the review process a little bit hard. please make sure the changes you made is necessary and useful.
Comment 3 tharvik 2014-06-23 09:27:56 UTC
Changelog (more or less):
 - EAPI=5
 - Use EGIT_BRANCH='next' instead of 'experimental' #506006
 - Use PYTHON_COMPAT to fix shebang in bin/uzbl-tabbed #456310
 - Fix sandbox in src_install in 9999 #486012
 - Fix QA of uzbl.desktop
 - Use ENABLE_GTK3 in 9999 #453208
 - Use emake -j1, upstream bug #351

#490348 is a duplicate of #456310

And the cosmetic changes are to avoid evaluating the string if there is no variables.

It is the same ebuild because it contains special cases to handle 9999 (is it the best way to do it?)
Comment 4 Sven Vermeulen (RETIRED) gentoo-dev 2014-07-06 12:20:23 UTC
The ebuilds are committed. I revbumped the 2012.05.14 one as it was stable already and the ebuild has undergone quite a few changes. Plus uzbl is a quick build (unlike its webkit-gtk dependency).

Thanks for the update!