Bug 511804

Summary:	OpenRC: tmpfiles.d's parser does not recognize unix styled comments
Product:	Gentoo Hosted Projects	Reporter:	consus
Component:	OpenRC	Assignee:	OpenRC Team <openrc>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	481182
Attachments:	This patch fixes the issue. Fixed patch

Description consus 2014-05-29 18:11:03 UTC

This line is considered valid

  1 |# Comment

however, on this one

  1| #Comment

tmpfiles.d's parser fails.
 
For example, parsing /usr/lib/tmpfiles.d/tor.conf (net-misc/tor) fails on the first line.

Reproducible: Always

Steps to Reproduce:
1. Modify an entry (or create a new one) in /usr/lib/tmpfiles.d
2. Run `rc-service tmpfiles.setup restart'
Actual Results:  
The 'ignoring invalid entry on line...' warning was printed.

Expected Results:  
The parser should not have failed on a comment.

Comment 1 consus 2014-05-29 18:12:42 UTC

Created attachment 377818 [details, diff]
This patch fixes the issue.

Comment 2 consus 2014-05-29 18:18:32 UTC

Created attachment 377820 [details, diff]
Fixed patch

Sorry, accidentally removed the wrong block.

Comment 3 William Hubbs gentoo-dev

2014-06-21 00:46:37 UTC

This is fixed in commit 094bc17 and will be in OpenRC-0.13.
Thanks for the report.