Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 509884

Summary: net-print/cups-filters-1.0.53 uclibc build fix
Product: Gentoo Linux Reporter: René Rhéaume <rene.rheaume>
Component: [OLD] PrintingAssignee: Printing Team <printing>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: AMD64   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: cups-filters-1.0.53-uclibc.patch
cups-filters-1.0.53.ebuild.patch

Description René Rhéaume 2014-05-08 22:42:51 UTC
uclibc does not support the mkstemps function, which prevent to build foomatic-rip. This patch use the mkstemp function on uclibc instead, with a modified filename pattern.

Reproducible: Always

Steps to Reproduce:
1. Install lilblue
2. emerge -1 cups-filters
Actual Results:  
emake failed

Expected Results:  
cups-filters installed on system
Comment 1 René Rhéaume 2014-05-08 22:43:54 UTC
Created attachment 376584 [details, diff]
cups-filters-1.0.53-uclibc.patch
Comment 2 René Rhéaume 2014-05-08 22:45:43 UTC
Created attachment 376586 [details, diff]
cups-filters-1.0.53.ebuild.patch
Comment 3 Anthony Basile gentoo-dev 2014-05-11 17:26:22 UTC
(In reply to René Rhéaume from comment #0)
> uclibc does not support the mkstemps function, which prevent to build
> foomatic-rip. This patch use the mkstemp function on uclibc instead, with a
> modified filename pattern.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Install lilblue
> 2. emerge -1 cups-filters
> Actual Results:  
> emake failed
> 
> Expected Results:  
> cups-filters installed on system

Many devs may not know what lilblue is.

I've added this to the hardened-development::uclibc overlay.  This patch should probably go upstream.
Comment 4 Anthony Basile gentoo-dev 2014-05-11 17:35:25 UTC
(In reply to Anthony Basile from comment #3)
> (In reply to René Rhéaume from comment #0)
> > uclibc does not support the mkstemps function, which prevent to build
> > foomatic-rip. This patch use the mkstemp function on uclibc instead, with a
> > modified filename pattern.
> > 
> > Reproducible: Always
> > 
> > Steps to Reproduce:
> > 1. Install lilblue
> > 2. emerge -1 cups-filters
> > Actual Results:  
> > emake failed
> > 
> > Expected Results:  
> > cups-filters installed on system
> 
> Many devs may not know what lilblue is.
> 
> I've added this to the hardened-development::uclibc overlay.  This patch
> should probably go upstream.

See "Bug reports" in 

http://www.linuxfoundation.org/collaborate/workgroups/openprinting/cups-filters

for how to submit upstream.
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2014-05-11 19:00:03 UTC
pinged upstream on irc
Comment 6 Andreas K. Hüttel archtester gentoo-dev 2014-05-11 19:13:54 UTC
Patch added. Just out of curiosity, why are you changing the filename format?
Comment 7 René Rhéaume 2014-05-12 00:04:10 UTC
(In reply to Andreas K. Hüttel from comment #6)
> Patch added. Just out of curiosity, why are you changing the filename format?

Both mkstemp and mkstemps create the file name and the file itself. If they only created the file name, I would have concatenated .log to the function result before creating the file, but that's not the case. I prefer not to reimplement mkstemps from scratch.
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2014-05-14 15:14:11 UTC
http://bzr.linuxfoundation.org/loggerhead/openprinting/cups-filters/revision/7202

Committed upstream.