Bug 50922 – add support for apache2 to apacheaddmod

• Product: Gentoo Linux
• Status: VERIFIED INVALID

[Description Minati jean michel 2004-05-13 05:08:01 UTC]

apacheaddmod is used in ebuilds to add apache modules to the configuration.
infortunatly,apacheaddmod seems to support apache 1.x only.
we should add support for apache 2.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Minati jean michel 2004-05-13 05:14:08 UTC]

Created attachment 31324 [details, diff]
Patch to add support for apache2.

This little patch add support for apache2.
I just added an option apache_version= , that allow to choose between apache's
versions.
this option is not mandatory,to keep up old behavior,by default the script
works for apache 1.x

[Comment 2 Chuck Short (RETIRED) 2004-05-13 05:23:35 UTC]

Dont add me to the cc since I already get the bug report from apache-bugs

[Comment 3 Minati jean michel 2004-05-13 05:31:39 UTC]

ok.

[Comment 4 Chuck Short (RETIRED) 2004-05-13 05:54:54 UTC]

Has this been tested?

[Comment 5 Minati jean michel 2004-05-13 06:15:44 UTC]

yes,it seems ok.

[Comment 6 Chuck Short (RETIRED) 2004-05-16 06:44:03 UTC]

Magnet,

This patch does not quite work the way I would expect it to. You are stil going to being adding modules to /etc/apache/conf which is not correct for apache2 modules.

chuck

[Comment 7 Minati jean michel 2004-05-17 03:01:32 UTC]

the config file to edit  is a command line argument.
for exemple :
# apacheaddmod /etc/apache2/conf/apache2.conf  test/mod_test.so mod_test.c test_module define=TEST apache_version=2

will edit /etc/apache2/conf/apache2.conf.

I didn t played with this option at all.it has been made by apacheaddmod's author.
I think we should keep this beahvior,since I'll send the patch upstream as soon as  it's in gentoo cvs.

[Comment 8 Minati jean michel 2004-05-25 05:28:26 UTC]

chuck ? did you tested it ?
I'll be glad to have some news , so I could start using it in ebuilds.

[Comment 9 Stuart Herbert (RETIRED) 2004-08-12 09:31:23 UTC]

First off, if both Apache 1 and Apache 2 are going to install apacheaddmod, it needs to be moved out into a separate package.

Secondly, does apachedelmod also need patching?

Third, support for apachedelmod needs adding to all the mod_* ebuilds in Portage.

I suggest we add 'apache2addmod' and 'apache2delmod' scripts (as links back to the original scripts), instead of passing the apache version as an option.  You can be sure that someone will forget to supply the option in an ebuild ...

Best regards,
Stu

[Comment 10 Minati jean michel 2004-09-20 05:31:07 UTC]

the incoming apache eclass should fix this.

[Comment 11 Elfyn McBratney (beu) (RETIRED) 2005-04-23 19:55:19 UTC]

It has, closing. :)