Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 508708

Summary: app-eselect/eselect-opengl: make updates atomic
Product: Gentoo Linux Reporter: SpanKY <vapier>
Component: Current packagesAssignee: Gentoo X packagers <x11>
Status: RESOLVED OBSOLETE    
Severity: normal CC: nikoli
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://crbug.com/351999
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 531842, 728286    
Bug Blocks:    
Attachments: 0001-update-env.d-entry-atomically.patch
0002-simplify-file-deletion.patch
0003-do-not-delete-related-files-when-updating.patch
0004-upgrade-files-atomically.patch

Description SpanKY gentoo-dev 2014-04-25 17:19:40 UTC
the current logic will `rm` files, then generate them in place.  this breaks parallel building in the system as there is a window where nothing exists.

i'd post a diff to the actual repo, but i have no idea where this thing is hosted.  the ebuilds and the source lacks details.
Comment 1 Matt Turner gentoo-dev 2014-04-25 18:44:47 UTC
Somewhat confusingly, eselect mesa and opengl (and a bunch of others) are in the 'extern' branch of http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=summary
Comment 2 SpanKY gentoo-dev 2014-04-25 19:31:27 UTC
Created attachment 375716 [details, diff]
0001-update-env.d-entry-atomically.patch
Comment 3 SpanKY gentoo-dev 2014-04-25 19:31:39 UTC
Created attachment 375718 [details, diff]
0002-simplify-file-deletion.patch
Comment 4 SpanKY gentoo-dev 2014-04-25 19:31:49 UTC
Created attachment 375720 [details, diff]
0003-do-not-delete-related-files-when-updating.patch
Comment 5 SpanKY gentoo-dev 2014-04-25 19:32:01 UTC
Created attachment 375722 [details, diff]
0004-upgrade-files-atomically.patch
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-12-31 12:25:08 UTC
eselect-opengl-1.3* no longer plays with symlinks, so atomicity has improved ;). We could try to create the two config files atomically but I don't think there's a big point in it.
Comment 7 SpanKY gentoo-dev 2015-02-17 11:52:17 UTC
(In reply to Michał Górny from comment #6)

unfortunately, updating the config files atomically is also important.  see the referenced CrOS bug report which started me investigating things.