| Summary: | app-emulation/virt-what-1.12 keyword request ppc ppc64 sparc | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Koen Zandberg <koen> |
| Component: | [OLD] Keywording and Stabilization | Assignee: | Doug Goldstein (RETIRED) <cardoe> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | prometheanfire, ruby, sysadmin |
| Priority: | Normal | Keywords: | KEYWORDREQ |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=394785 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 276857 | ||
| Bug Blocks: | |||
| Attachments: | Remove redundant src_install(), add IUSE=dmi | ||
|
Description
Koen Zandberg
2014-04-15 11:22:21 UTC
Given that this is advertised as a "heavy" fact and that there is a fallback I'm thinking we should probably pull this in via a USE flag. Is there a generic "virtual machine" type USE flag? arches, please keyword app-emulation/virt-what for {hppa,ppc,ppc64,sparc}.
Where is the dev-ruby/facter that uses this? ... facter seems bent on getting dmidecode on everyone's system, isn't it? See bug #394785. http://docs.puppetlabs.com/facter/1.6/release_notes.html#add-a-heavy-virtual-fact-using-virt-what so, 1.6 and above. Can you stick that sys-apps/dmidecode dependency behind a USE flag or introduce USE=dmi in app-emulation/virt-what for that purpose? /usr/sbin/virt-what appears to be a shell script that handles "command not found" just fine. Created attachment 376480 [details, diff]
Remove redundant src_install(), add IUSE=dmi
Hello? (In reply to Jeroen Roovers from comment #10) > Hello? Go ahead and apply it. It seems reasonable. Marked ~hppa. still need ppc ppc64 sparc *** Bug 513288 has been marked as a duplicate of this bug. *** Keyword ~ppc and ~ppc64 ~sparc done |
